From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934016AbcAYRrU (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 12:47:20 -0500
Received: from quartz.orcorp.ca ([184.70.90.242]:45179 "EHLO quartz.orcorp.ca"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932942AbcAYRrR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 12:47:17 -0500
Date: Mon, 25 Jan 2016 10:47:05 -0700
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Colin King <colin.king@canonical.com>
Cc: Doug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        Ira Weiny <ira.weiny@intel.com>, Christoph Lameter <cl@linux.com>,
        Matan Barak <matanb@mellanox.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/sysfs: remove unused va_list args
Message-ID: <20160125174705.GA28108@obsidianresearch.com>
References: <1453742627-24698-1-git-send-email-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1453742627-24698-1-git-send-email-colin.king@canonical.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Yep. This is bad new breakage too. Care to add a fixes line?

Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Jason