From: Dave Jones <davej@codemonkey.org.uk>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
heiko.carstens@de.ibm.com, akpm@linux-foundation.org,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default
Date: Mon, 25 Jan 2016 14:38:20 -0500 [thread overview]
Message-ID: <20160125193820.GA22444@codemonkey.org.uk> (raw)
In-Reply-To: <20160125192210.GA20919@codemonkey.org.uk>
On Mon, Jan 25, 2016 at 02:22:10PM -0500, Dave Jones wrote:
> > A default mode would be ok for me as it makes things obvious. Will send
> > a patch.
>
> The messaging around changing a default like this was really poor.
> When we do behaviour changes like this, we typically rename the CONFIG option
> to make it obvious that things aren't as they used to be.
Looking at this closer, shouldn't the original diff to make this runtime
have also changed the x86 implementation details in arch/x86/mm/pageattr.c ?
Even when we don't boot with the enable flag, we're doing the "split 2M page into 4Ks"
thing. It looks like a s/debug_pagealloc/debug_pagealloc_enabled()/ might
do the right thing maybe ?
It's almost comedic that I walked into change c9e0d39126af thinking all this
stuff was working _because_ we were doing that page splitting.
Dave
next prev parent reply other threads:[~2016-01-25 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 11:44 [PATCH/RFC] mm/debug_pagealloc: enable it by default Christian Borntraeger
2016-01-25 6:41 ` Joonsoo Kim
2016-01-25 8:21 ` Christian Borntraeger
2016-01-25 19:22 ` Dave Jones
2016-01-25 19:38 ` Dave Jones [this message]
2016-01-25 19:51 ` Christian Borntraeger
2016-01-26 6:18 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125193820.GA22444@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).