From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933790AbcAYUnG (ORCPT ); Mon, 25 Jan 2016 15:43:06 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35784 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933706AbcAYUnE (ORCPT ); Mon, 25 Jan 2016 15:43:04 -0500 Date: Mon, 25 Jan 2016 15:43:00 -0500 From: Tejun Heo To: Brijesh Singh Cc: linux-kernel@vger.kernel.org, hdegoede@redhat.com, arnd@arndb.de, linux-ide@vger.kernel.org Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver Message-ID: <20160125204300.GM3628@mtj.duckdns.org> References: <1452789071-4090-1-git-send-email-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452789071-4090-1-git-send-email-brijesh.singh@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2016 at 10:31:11AM -0600, Brijesh Singh wrote: > AMD Seattle SATA controller mostly conforms to AHCI interface with some > special register to control SGPIO interface. In the case of an AHCI > controller, the SGPIO feature is ideally implemented using the > "Enclosure Management" register of the AHCI controller, but those > registeres are not implemented in the Seattle SoC. Instead SoC > (Rev B0 onwards) provides a 32-bit SGPIO control register which should > be programmed to control the activity, locate and fault LEDs. > > The driver is based on ahci_platform driver. > > Signed-off-by: Brijesh Singh > Acked-by: Hans de Goede > CC: tj@kernel.org > CC: linux-ide@vger.kernel.org Hans, can you please review the patch? Thanks. -- tejun