From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758562AbcAYVMs (ORCPT ); Mon, 25 Jan 2016 16:12:48 -0500 Received: from mail.kernel.org ([198.145.29.136]:45101 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757563AbcAYVMr (ORCPT ); Mon, 25 Jan 2016 16:12:47 -0500 Date: Mon, 25 Jan 2016 18:12:42 -0300 From: Arnaldo Carvalho de Melo To: Mathieu Poirier Cc: linux-doc@vger.kernel.org, Ingo Molnar , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Peter Zijlstra Subject: Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num() non static Message-ID: <20160125211242.GF22501@kernel.org> References: <1452807977-8069-1-git-send-email-mathieu.poirier@linaro.org> <1452807977-8069-21-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 25, 2016 at 01:46:22PM -0700, Mathieu Poirier escreveu: > On 14 January 2016 at 14:46, Mathieu Poirier wrote: > > For memory allocation purposes, code located in other places > > then util/cpumap.c may want to know how many CPUs the system has. > > > > This patch is making function set_max_cpu_num() available to > > other parts of the perf tool so that global variable > > 'max_cpu_num' gets the right value when referenced by cpu__max_cpu(). > > > > Cc: Peter Zijlstra > > Cc: Ingo Molnar > > Cc: Arnaldo Carvalho de Melo > > Signed-off-by: Mathieu Poirier > > --- > > tools/perf/util/cpumap.c | 2 +- > > tools/perf/util/cpumap.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c > > index 10af1e7524fb..ae179320c0c0 100644 > > --- a/tools/perf/util/cpumap.c > > +++ b/tools/perf/util/cpumap.c > > @@ -380,7 +380,7 @@ out: > > } > > > > /* Determine highest possible cpu in the system for sparse allocation */ > > -static void set_max_cpu_num(void) > > +void set_max_cpu_num(void) > > { > > const char *mnt; > > char path[PATH_MAX]; > > diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h > > index 85f7772457fa..45fa963345eb 100644 > > --- a/tools/perf/util/cpumap.h > > +++ b/tools/perf/util/cpumap.h > > @@ -14,6 +14,7 @@ struct cpu_map { > > int map[]; > > }; > > > > +void set_max_cpu_num(void); > > struct cpu_map *cpu_map__new(const char *cpu_list); > > struct cpu_map *cpu_map__empty_new(int nr); > > struct cpu_map *cpu_map__dummy_new(void); > > -- > > 2.1.4 > > > > Arnaldo, > > I can't queue this patch for 4.6 without at least a reviewed by from you. This one I remember, looks ugly, the name set_max_cpu_num() looks strange, when that was restricted (static) to that cpumap.c file, it wasn't a problem, exporting it for wider usage looks bad. You've been waiting for this for quite a while, it seems, lemme stop what I am doing to check this... - Arnaldo > It has been rebased to 4.5-rc1 here [1] for your convenience. I will > be happy to use another baseline should that be more adequate for you. > The same goes for [2] > > Thanks, > Mathieu > > [1]. https://git.linaro.org/people/mathieu.poirier/coresight.git/shortlog/refs/heads/perf-v4.5-rc1-V8