From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933412AbcAZBsZ (ORCPT ); Mon, 25 Jan 2016 20:48:25 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34802 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932318AbcAZBsT (ORCPT ); Mon, 25 Jan 2016 20:48:19 -0500 Date: Tue, 26 Jan 2016 10:49:30 +0900 From: Sergey Senozhatsky To: linux-block@vger.kernel.org Cc: Minchan Kim , Andrew Morton , "Theodore Ts'o" , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: [4.5.0-rc1/-next] unaligned bio-s Message-ID: <20160126014930.GA515@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, With 4.5.0-rc1/linux-next I see unaligned requests passed to zram block device. bio->bi_iter.bi_size is expected to be ZRAM_LOGICAL_BLOCK_SIZE (1 << 12) aligned. un-aligned example: :: SIZE 130560 size & (ZRAM_LOGICAL_BLOCK_SIZE - 1) [ 5695.340294] Call Trace: [ 5695.340298] [] dump_stack+0x4e/0x79 [ 5695.340302] [] warn_slowpath_common+0x99/0xb2 [ 5695.340305] [] ? zram_make_request+0x155/0x494 [zram] [ 5695.340307] [] warn_slowpath_null+0x1a/0x1c [ 5695.340310] [] zram_make_request+0x155/0x494 [zram] [ 5695.340314] [] generic_make_request+0xbd/0x15b [ 5695.340316] [] submit_bio+0xf5/0x11e [ 5695.340319] [] ? __test_set_page_writeback+0x192/0x1aa [ 5695.340323] [] ext4_io_submit+0x3e/0x52 [ 5695.340325] [] ext4_bio_write_page+0x1c9/0x2f3 [ 5695.340328] [] mpage_submit_page+0x5f/0x75 [ 5695.340330] [] mpage_map_and_submit_buffers+0x10f/0x21d [ 5695.340333] [] ext4_writepages+0xc96/0xe31 [ 5695.340336] [] do_writepages+0x23/0x2c [ 5695.340337] [] ? do_writepages+0x23/0x2c [ 5695.340339] [] __writeback_single_inode+0xe2/0x656 [ 5695.340342] [] writeback_sb_inodes+0x288/0x45e [ 5695.340344] [] __writeback_inodes_wb+0x76/0xae [ 5695.340346] [] wb_writeback+0x1aa/0x496 [ 5695.340349] [] wb_workfn+0x259/0x56a [ 5695.340351] [] ? wb_workfn+0x259/0x56a [ 5695.340353] [] ? lock_acquire+0x10d/0x1a8 [ 5695.340357] [] process_one_work+0x29e/0x58b [ 5695.340359] [] worker_thread+0x291/0x383 [ 5695.340361] [] ? rescuer_thread+0x2cf/0x2cf [ 5695.340363] [] kthread+0x107/0x10f [ 5695.340366] [] ? kthread_create_on_node+0x1ea/0x1ea [ 5695.340369] [] ret_from_fork+0x3f/0x70 [ 5695.340371] [] ? kthread_create_on_node+0x1ea/0x1ea [ 5695.340373] ---[ end trace 90ed50ba3553c47d ]--- bio->bi_iter.bi_sector is expected to be ZRAM_SECTOR_PER_LOGICAL_BLOCK (1 << 3) aligned. un-aligned example: :: START 264655 start & (ZRAM_SECTOR_PER_LOGICAL_BLOCK - 1) [ 5695.340428] Call Trace: [ 5695.340430] [] dump_stack+0x4e/0x79 [ 5695.340432] [] warn_slowpath_common+0x99/0xb2 [ 5695.340435] [] ? zram_make_request+0xac/0x494 [zram] [ 5695.340437] [] warn_slowpath_null+0x1a/0x1c [ 5695.340440] [] zram_make_request+0xac/0x494 [zram] [ 5695.340442] [] ? blk_queue_exit+0xcf/0x111 [ 5695.340444] [] generic_make_request+0xbd/0x15b [ 5695.340446] [] submit_bio+0xf5/0x11e [ 5695.340448] [] ? __test_set_page_writeback+0x192/0x1aa [ 5695.340450] [] ext4_io_submit+0x3e/0x52 [ 5695.340452] [] ext4_bio_write_page+0x1c9/0x2f3 [ 5695.340455] [] mpage_submit_page+0x5f/0x75 [ 5695.340457] [] mpage_map_and_submit_buffers+0x10f/0x21d [ 5695.340459] [] ext4_writepages+0xc96/0xe31 [ 5695.340462] [] do_writepages+0x23/0x2c [ 5695.340464] [] ? do_writepages+0x23/0x2c [ 5695.340466] [] __writeback_single_inode+0xe2/0x656 [ 5695.340468] [] writeback_sb_inodes+0x288/0x45e [ 5695.340471] [] __writeback_inodes_wb+0x76/0xae [ 5695.340473] [] wb_writeback+0x1aa/0x496 [ 5695.340475] [] wb_workfn+0x259/0x56a [ 5695.340477] [] ? wb_workfn+0x259/0x56a [ 5695.340479] [] ? lock_acquire+0x10d/0x1a8 [ 5695.340481] [] process_one_work+0x29e/0x58b [ 5695.340484] [] worker_thread+0x291/0x383 [ 5695.340486] [] ? rescuer_thread+0x2cf/0x2cf [ 5695.340487] [] kthread+0x107/0x10f [ 5695.340490] [] ? kthread_create_on_node+0x1ea/0x1ea [ 5695.340492] [] ret_from_fork+0x3f/0x70 [ 5695.340494] [] ? kthread_create_on_node+0x1ea/0x1ea [ 5695.340496] ---[ end trace 90ed50ba3553c47e ]--- dmesg: ... [ 6228.393546] Buffer I/O error on device zram0, logical block 33050 [ 6228.393549] Buffer I/O error on device zram0, logical block 33051 [ 6228.393551] Buffer I/O error on device zram0, logical block 33052 [ 6228.393553] Buffer I/O error on device zram0, logical block 33053 [ 6228.393555] Buffer I/O error on device zram0, logical block 33054 [ 6228.393557] Buffer I/O error on device zram0, logical block 33055 [ 6228.393559] Buffer I/O error on device zram0, logical block 33056 [ 6228.393561] Buffer I/O error on device zram0, logical block 33057 [ 6228.393563] Buffer I/O error on device zram0, logical block 33058 [ 6228.393565] Buffer I/O error on device zram0, logical block 33059 [ 6228.393921] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 152 (offset 0 size 2101248 starting block 33561) [ 6228.394278] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 152 (offset 0 size 3149824 starting block 33817) [ 6228.394633] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 152 (offset 0 size 4198400 starting block 34073) [ 6228.394990] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 152 (offset 0 size 5246976 starting block 34329) [ 6228.395211] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 152 (offset 0 size 5484544 starting block 34361) [ 6228.395607] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 153 (offset 0 size 1052672 starting block 34644) [ 6228.395811] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 153 (offset 0 size 1196032 starting block 34676) [ 6228.397060] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 154 (offset 0 size 1052672 starting block 34936) [ 6228.397467] EXT4-fs warning (device zram0): ext4_end_bio:328: I/O error -5 writing to inode 154 (offset 0 size 2101248 starting block 35192) ... Is this a known issue? -ss