From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933995AbcAZIXu (ORCPT ); Tue, 26 Jan 2016 03:23:50 -0500 Received: from down.free-electrons.com ([37.187.137.238]:49091 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932135AbcAZIXr (ORCPT ); Tue, 26 Jan 2016 03:23:47 -0500 Date: Tue, 26 Jan 2016 09:23:45 +0100 From: Alexandre Belloni To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Wei-Ning Huang , Eddie Huang , Tianping Fang , Henry Chen , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: mt6397: add IRQ domain dependency Message-ID: <20160126082345.GD11740@piout.net> References: <1453737892-1960479-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453737892-1960479-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/2016 at 17:04:46 +0100, Arnd Bergmann wrote : > The mt6397 RTC driver can be built either when the MFD_MT6397 driver > is enabled (which selects IRQ_DOMAIN), or when compile testing. > The latter however fails without IRQ domains: > > drivers/rtc/rtc-mt6397.c: In function 'mtk_rtc_probe': > drivers/rtc/rtc-mt6397.c:326:13: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration] > rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start); > > This adds an explicit dependency for the COMPILE_TEST case. > > Signed-off-by: Arnd Bergmann Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com