From: Andrew Morton <akpm@linux-foundation.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org, Prarit Bhargava <prarit@redhat.com>
Subject: Re: [PATCH] lib/bug: make panic_on_warn available for all architectures
Date: Tue, 26 Jan 2016 15:14:08 -0800 [thread overview]
Message-ID: <20160126151408.85a48aa035a4e72243d4003c@linux-foundation.org> (raw)
In-Reply-To: <1453468336-60133-1-git-send-email-heiko.carstens@de.ibm.com>
On Fri, 22 Jan 2016 14:12:16 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> Christian Borntraeger reported that panic_on_warn doesn't have any
> effect on s390.
>
> The panic_on_warn feature was introduced with 9e3961a09798 ("kernel:
> add panic_on_warn"). However it did care only for the case when
> WANT_WARN_ON_SLOWPATH is defined. This is turn is only the case for
> architectures which do not have an own __WARN_TAINT defined.
>
> Other architectures which do have __WARN_TAINT defined call
> report_bug() for warnings within lib/bug.c which does not call panic()
> in case panic_on_warn is set.
>
> Let's simply enable the panic_on_warn feature by adding the same code
> like it was added to warn_slowpath_common() in panic.c.
>
> This enables panic_on_warn also for arm64, parisc, powerpc, s390 and
> sh.
>
It's a bit sad to do this in two places. You couldn't find a suitable
place which is effective for all architectures?
next prev parent reply other threads:[~2016-01-26 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 13:12 [PATCH] lib/bug: make panic_on_warn available for all architectures Heiko Carstens
2016-01-22 13:41 ` Christian Borntraeger
2016-01-22 13:53 ` Prarit Bhargava
2016-01-26 23:14 ` Andrew Morton [this message]
2016-02-01 14:06 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126151408.85a48aa035a4e72243d4003c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox