From: Jeff Merkey <linux.mdb@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Don Zickus <dzickus@redhat.com>,
Ulrich Obergfell <uobergfe@redhat.com>,
Aaron Tomlin <atomlin@redhat.com>, Michal Hocko <mhocko@suse.cz>,
Frederic Weisbecker <fweisbec@gmail.com>,
Tejun Heo <tj@kernel.org>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Chris Metcalf <cmetcalf@ezchip.com>
Subject: [PATCH v2] Add hard/soft lockup debugger entry points
Date: Tue, 26 Jan 2016 10:04:54 -0700 [thread overview]
Message-ID: <20160126170454.GA28216@localhost.localdomain> (raw)
This patch adds an export which can be set by system debuggers to direct
the hard lockup and soft lockup detector to trigger a breakpoint exception
and enter a debugger if one is active. It is assumed that if someone
sets this variable, then an breakpoint handler of some sort will be actively
loaded or registered via the notify die handler chain.
This addition is extremely useful for debugging hard and soft lockups
real time and quickly from a console debugger.
Signed-off-by: Jeff Merkey <linux.mdb@gmail.com>
---
kernel/watchdog.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index b3ace6e..c28e58c 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -23,6 +23,7 @@
#include <linux/workqueue.h>
#include <asm/irq_regs.h>
+#include <linux/kgdb.h>
#include <linux/kvm_para.h>
#include <linux/perf_event.h>
#include <linux/kthread.h>
@@ -108,6 +109,9 @@ static DEFINE_PER_CPU(struct perf_event *, watchdog_ev);
#endif
static unsigned long soft_lockup_nmi_warn;
+int debug_watchdog_lockups;
+EXPORT_SYMBOL_GPL(debug_watchdog_lockups);
+
/* boot commands */
/*
* Should we panic when a soft-lockup or hard-lockup occurs:
@@ -358,6 +362,9 @@ static void watchdog_overflow_callback(struct perf_event *event,
else
dump_stack();
+ if (debug_watchdog_lockups)
+ arch_kgdb_breakpoint();
+
/*
* Perform all-CPU dump only once to avoid multiple hardlockups
* generating interleaving traces
@@ -478,6 +485,9 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
else
dump_stack();
+ if (debug_watchdog_lockups)
+ arch_kgdb_breakpoint();
+
if (softlockup_all_cpu_backtrace) {
/* Avoid generating two back traces for current
* given that one is already made above
--
1.8.3.1
next reply other threads:[~2016-01-26 17:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 17:04 Jeff Merkey [this message]
2016-01-26 17:22 ` [PATCH v2] Add hard/soft lockup debugger entry points Chris Metcalf
2016-01-26 17:26 ` Jeff Merkey
2016-01-26 17:45 ` kbuild test robot
2016-01-26 18:46 ` kbuild test robot
2016-01-26 19:33 ` Jeff Merkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126170454.GA28216@localhost.localdomain \
--to=linux.mdb@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=cmetcalf@ezchip.com \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).