From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967318AbcAZS3N (ORCPT ); Tue, 26 Jan 2016 13:29:13 -0500 Received: from mail-bl2nam02on0047.outbound.protection.outlook.com ([104.47.38.47]:50953 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965771AbcAZS3L (ORCPT ); Tue, 26 Jan 2016 13:29:11 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Tue, 26 Jan 2016 10:30:56 -0800 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Jisheng Zhang CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 05/13] mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove() Message-ID: <20160126183056.GH12716@xsjsorenbubuntu> References: <1453803353-6266-1-git-send-email-jszhang@marvell.com> <1453803353-6266-6-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453803353-6266-6-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22090.002 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(377424004)(189002)(199003)(54356999)(5001960100002)(2950100001)(85202003)(106466001)(1220700001)(110136002)(11100500001)(6806005)(50986999)(5008740100001)(77096005)(586003)(19580395003)(76176999)(81156007)(1076002)(4001350100001)(36386004)(189998001)(47776003)(2870700001)(85182001)(87936001)(50466002)(19580405001)(33656002)(76506005)(63266004)(83506001)(4326007)(1096002)(230783001)(2906002)(33716001)(23676002)(86362001)(92566002)(57986006)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1NAM02HT245;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: dd004ede-2071-4fce-5a6b-08d3267e9423 X-Exchange-Antispam-Report-Test: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1NAM02HT245;UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: <7633d337c771433486869a562b4eabba@CY1NAM02HT245.eop-nam02.prod.protection.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13023025)(8121501046)(520078)(5005006)(13017025)(13018025)(13024025)(3002001)(10201501046);SRVR:CY1NAM02HT245;BCL:0;PCL:0;RULEID:;SRVR:CY1NAM02HT245; X-Forefront-PRVS: 08331F819E X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2016 18:29:07.2607 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT245 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-01-26 at 06:15PM +0800, Jisheng Zhang wrote: > sdhci_pltfm_unregister() could operate host's registers, it will cause > problems if the clk is already disabled and unprepared. Fix this issue > by moving the clk_disable_unprepare() call to the end of remove > function. > > Signed-off-by: Jisheng Zhang Acked-by: Sören Brinkmann Sören