From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751551AbcAZX5r (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Jan 2016 18:57:47 -0500
Received: from one.firstfloor.org ([193.170.194.197]:33192 "EHLO
	one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750991AbcAZX5o (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Jan 2016 18:57:44 -0500
Date: Wed, 27 Jan 2016 00:57:43 +0100
From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>, acme@kernel.org, jolsa@kernel.org,
        mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into
 printout
Message-ID: <20160126235743.GH31686@two.firstfloor.org>
References: <1453256812-24006-1-git-send-email-andi@firstfloor.org>
 <1453256812-24006-4-git-send-email-andi@firstfloor.org>
 <20160122094153.GC27246@krava.brq.redhat.com>
 <20160123034304.GD31686@two.firstfloor.org>
 <20160123161958.GA30110@krava.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160123161958.GA30110@krava.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 23, 2016 at 05:19:58PM +0100, Jiri Olsa wrote:
> On Sat, Jan 23, 2016 at 04:43:05AM +0100, Andi Kleen wrote:
> > > > -		if (run == 0 || ena == 0) {
> > > > -			fprintf(output, "CPU%*d%s%*s%s",
> > > > -				csv_output ? 0 : -4,
> > > > -				perf_evsel__cpus(counter)->map[cpu], csv_sep,
> > > > -				csv_output ? 0 : 18,
> > > > -				counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> > > > -				csv_sep);
> > > 
> > > this hunk is not preserved in the new code.. I guess the output is
> > > different for -A if counter wasn't meassure?
> > 
> > The code for this is common in printout() now.
> 
> but what will be printed for -A not counted counters?
> not the "CPU%*d%s%*s%s" ...


CPU0       <not supported>      stalled-cycles-backend                                      
CPU1       <not supported>      stalled-cycles-backend                                      
CPU2       <not supported>      stalled-cycles-backend                                      
CPU3       <not supported>      stalled-cycles-backend                                      
CPU4       <not supported>      stalled-cycles-backend                                      
CPU5       <not supported>      stalled-cycles-backend                                      
CPU6       <not supported>      stalled-cycles-backend                                      
CPU7       <not supported>      stalled-cycles-backend                                      
CPU8       <not supported>      stalled-cycles-backend                                      
CPU9       <not supported>      stalled-cycles-backend                                      
CPU10      <not supported>      stalled-cycles-backend                                      
CPU11      <not supported>      stalled-cycles-backend                                      

-Andi