From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933179AbcA0OTI (ORCPT ); Wed, 27 Jan 2016 09:19:08 -0500 Received: from mail-by2on0092.outbound.protection.outlook.com ([207.46.100.92]:41712 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932555AbcA0OTF (ORCPT ); Wed, 27 Jan 2016 09:19:05 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@caviumnetworks.com; Date: Wed, 27 Jan 2016 15:18:47 +0100 From: Robert Richter To: Hanjun Guo CC: "Rafael J. Wysocki" , Will Deacon , Catalin Marinas , , , , Ganapatrao Kulkarni , Lorenzo Pieralisi , Shannon Zhao , Steve Capper , Mark Rutland , Hanjun Guo Subject: Re: [PATCH v3 12/12] acpi, numa: reuse acpi_numa_memory_affinity_init() Message-ID: <20160127141847.GR24726@rric.localdomain> References: <1453541967-3744-1-git-send-email-guohanjun@huawei.com> <1453541967-3744-13-git-send-email-guohanjun@huawei.com> <20160125102643.GF24726@rric.localdomain> <56A8606A.8080407@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <56A8606A.8080407@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.194.222] X-ClientProxiedBy: DB4PR07CA014.eurprd07.prod.outlook.com (10.242.229.24) To BN3PR0701MB1605.namprd07.prod.outlook.com (25.163.38.28) X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1605;2:c54r0YSrdPhQowvmpo4UR9amtz9OXaQUQsCnfrjoz+oABeJFH5s2gF3gBmvomGM2yVIs65zntagi9arAP74PDClhFk81xADd2CCp7xSjl6Ky7wywbD4k0ZiuIeJ5rxOX8kOZjSAp4v9pK+xzvMpSDg==;3:PrPX72RtRH1qBA3CI/1tmzyMdrZv20lz6MtSto3xC+H1IEje/vfMVkp1SUA9rmwgjh+C10GkBHCf/+tfqmXDvfiG2o6LYDFRaVZm/zfwZk2akyg6O/CBF/rSDiKZH2cW;25:qh2J2Kss/RZ1v1ew3I46l6ZZrWpG27bITbocyhJ3YRmEyaCI+fK+IL2oBufgNO2LHO5f3b1+YVslaYC4jzfrFEgY+mD0CznhageL+Sn2iQpFb4Xr1EhBimO/H4juVPLQle0aTI/oU30m4S9n7LyeyiHjWxf+4d1fWM3q7OGeTZaGuIFv7615i27ITvXwFvyNPc2kNj6I2Cs3q3QFFwYb01gzgZsLSpMEiFzD1lGWLEmf+srukmyzDWoukhqDIJ8A X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1605; X-MS-Office365-Filtering-Correlation-Id: 0d6e6d27-3ca3-40da-cb97-08d32724cea7 X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1605;20:jSzEjZFgrT1dP2gXNLgaav6r4Mr8tNZXawJ5z9t7dpKEXbdLgFkrbyHv8IRHxsz3We5i8HUIFdAomm5Q2B4yywxZofFhpQ4aUn/yIiqfSUWbV2wFx4GByI5UIB7YW3nrmiEaVJIB/nDNSygRCDJa8urgkHYVUmH4NAmRtnYcDKIWqwlNAQKZadNGwb/qo/boiVkoeU2yUJHaf41CRvamwgn1M0QekZVeypZEQe5PR2VPWW4eqkqcU7HE2R0MXPNCWlrYDxmMrOQC9YpXpftGYJ+1SdTL6p5DFEPIy4op4ogXI8yEBcaSz6PsICDyLhz0B1bqs+7KUNV/LygN4Nzrcv1s3ZPCe10UHVpYkyE3ORqlZ2L1NGnuS1d1u5RmDLIcCwbGZDpI9NqtjjU1npUsf/IcwyMxyMSmuvX2wssXvfu8dz1oJdZiWeqMfMdSTviGSlYgEIEfvthxUYgIzOKXPuINPOVa58NZKLNX05YlG8qyb36mUNGWEaObkb7PlmzkRXFHLn2qk0ZFEvrKd+Mg0rEBSl+NP+vTqCRQwR2N4QEchjsybubGk4JkuUHRQmuusKZrbtnz+Qb513fFjd6FLlcMIpneASXthk6LiSnNxzg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN3PR0701MB1605;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1605; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1605;4:MtGdw4qeCx4nRjqy6FRlMf/SQEOpOLpfUAsC1Uk6nK/Rm3ybd+fHnhtlP2HO71RoYKXaR5h2AC2I5WnW5sEz00P0zwqbiPilNGjNx5fWbGpf8VYHAyblaAv1HcnQ/sOcdS/TxRKAXSjkeQuRvkzRq81mAYma61tDGpT0NpPHWVnPNNF+1u0OrLFgvWzfRJJgTfX5szrhtFEXkzuiEWr/RlqJg8Ey34HsXu3XpYtP2fi8LMg2c9c/ek5TKgKu+aLUT+BXw+6pWadDuDJLPiONICguzrFPV8dum7qN0ODSswpM2D834BXpoHze527+zf0fLZpypA6upN2b3Xb1kEIv1OPr7mdRfiwYo2+mUW9bji3otXGbXEHAzT7A0GnzM22B X-Forefront-PRVS: 0834BAF534 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(479174004)(24454002)(189002)(199003)(5001960100002)(54356999)(19580405001)(3846002)(23726003)(2950100001)(110136002)(1076002)(50986999)(106356001)(81156007)(66066001)(33656002)(4001350100001)(97736004)(77096005)(76176999)(47776003)(3470700001)(101416001)(189998001)(586003)(105586002)(87976001)(1096002)(6116002)(19580395003)(5008740100001)(83506001)(2906002)(50466002)(5004730100002)(42186005)(46406003)(4326007)(86362001)(92566002)(40100003)(97756001)(93886004)(122386002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1605;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0701MB1605;23:uLnt6odJzFPmbQP0g4+DKvh+sjg6pL1+l1xlpit?= =?us-ascii?Q?ouJXzgqcMcRx+uKYbVDQbJKfR1fhyHfsX8EfGYwCKovi5nNRStUC1OvG0SrM?= =?us-ascii?Q?qRIBL3xogg4T3pI3EPXEPtQ0tb1ZRkt/TuSigHcO4ywY92lo11XMLBjCxd/K?= =?us-ascii?Q?unBic1ucyYRMwACH4Gv89/Iks+RUyLsdNmlEB5UOIhDDNrxKts1Vecq3VLfk?= =?us-ascii?Q?oisWFPnuLCtOTkU80w+7Yg5xT0xqFRswLff44jZK5+3LzAdZS8bpfu+CSE3+?= =?us-ascii?Q?ZqwkyUMlaUFXYirae03WIvx5HjqPN0FABOAIjH9Ec5jDdX78Vs7tmJYTLT4H?= =?us-ascii?Q?ta9n6smij1hpn9SemxzkacXC/UlUojCGsSzlcoHBvznzYWsZBYCTa/l6lvKH?= =?us-ascii?Q?lP6kdLAYrDT35uOelHneBp4ELtjhzyOeZKztEOfXBzELAawftdw6aMxGwsYG?= =?us-ascii?Q?/TZIkO8255LhiUQ7PHw3KAXn47MCD1T1oW6/aypElh4CaQHjurE8A6dHFJkn?= =?us-ascii?Q?+SOyRATIPm9g+AW6Tg9IS5WNQYvgyIkPIYNAzgYFnuJFwTj0jmyMOmI1IIyI?= =?us-ascii?Q?LiVioUK4EGRc1FPCuyu7rdK4tOZ0xLa5LH4U0zMNZPbZE/qbh4QFo/sqy0yF?= =?us-ascii?Q?HziHFzA/TpiR0mN65foKWJOIKbCAvyxGSz3QGCEzYjnyy/60BeRroVaVmVqo?= =?us-ascii?Q?ZOOTXxg1mbsQI1tl12zuQrt7omvrQ/juV8Vg/gYcFREiSVPeCP4NTtQLYZHb?= =?us-ascii?Q?X2mOMWS3vI/KAp10Mfy4C1drLCISCMAVGYjapJXZgHZfoTgC2H1oBRF+py+0?= =?us-ascii?Q?pW+EYK5OjPr1FNckDounjm4ADwjvDGiaheidSWjeogXAnUDLpOdAOt6ztOxH?= =?us-ascii?Q?uTXYQGck2FnJf7jPCl7q+hsmE7CvlFCyd4rBes6SIdvWHgthlfB81l0aMdqK?= =?us-ascii?Q?iC5hStfDeO+bxkoEtMp+53wA9BZgOXqCTb+4aidXoOmgJhQURUAnx+iPUard?= =?us-ascii?Q?xFmDp3GUMuzKDq4ZDmRX2Fp9ZpL3vtDquz4EDdVqc/kGZdn0o5V6nlfkcYhM?= =?us-ascii?Q?x5xUxaBfpeceMPM44WeBwoTpLQ/pexPttZPTzvI6M06yw1rG6KA3sv+ifSI3?= =?us-ascii?Q?9PcQ8JAP43N9AJbAAFMSOjsyAXnkE0HOjpmh9/ZvkRAvFLniut6so179jGRw?= =?us-ascii?Q?91GxEtw4LRhUfbXU=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1605;5:nSoB+/XxUo+C81H+bvZSONXg8FPLKrZNhXKCEIo9T7SkGmNXSDfHt3J/xLLoI1W7M6MxSUuo5PBAFlQE0F9CooD8tnzpzSR9TMTpgfY+SkMtV3UZXtCXiBF2khuddEmTAp2whCo0WipsVwpayQsh4g==;24:nwVMswB/rdyawc9f37MxuSO5qnDjo34U/xt0bGVa9LDivDj19BCkwQPgzcq5CtNCSxT94vLVHQSzwf9pEeqai0ScUb+MdOa1A/QTR3U+3lk= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2016 14:19:00.5498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1605 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.01.16 14:15:06, Hanjun Guo wrote: > Hi Robert, > > On 2016/1/25 18:26, Robert Richter wrote: > > On 23.01.16 17:39:27, Hanjun Guo wrote: > >> From: Hanjun Guo > >> > >> After the cleanup for acpi_numa_memory_affinity_init(), > >> it can be used for architetures both x86 and arm64, since > >> CONFIG_MEMORY_HOTPLUG is not enabled for arm64, so no > >> worry about that. > >> > >> Signed-off-by: Hanjun Guo > >> --- > >> arch/arm64/kernel/acpi_numa.c | 42 ------------------------------- > >> arch/x86/mm/srat.c | 54 ---------------------------------------- > >> drivers/acpi/numa.c | 57 +++++++++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 57 insertions(+), 96 deletions(-) > > This one reverts acpi_numa_memory_affinity_init() to the x86 version. > > I rather would prefer the arm64 version for the generic code. We could > > keep the x86 implementation until x86 maintainers agree to remove them > > and use the generic one (implemented in a separate patch). > > > > Doing so we can move acpi_numa_memory_affinity_init() from the > > beginning to generic code (used for arm64) and have this last patch to > > remove the x86 version. > > I think the x86 version is the generic one, all the flags (ACPI_SRAT_MEM_HOT_PLUGGABLE and > etc) are defined in the ACPI spec, x86 just use all the flags because it support such features. > For ARM64, firmware should be careful and represent the true platform configuration to > OS, such as on ARM64, we can't set hotpluggable flag as the ARM64 arch don't support > memory hot-plug yet (also the firmware don't support it too), if firmware do things right, > it will be not worries for the kernel. But you are removing all arm64 from your first patches. Why do you introduce acpi_numa_memory_affinity_init() in the beginning to remove it in the end again? I esp. like the arm64 version because of its direct returns. So I still would like to see generic code for arm64 from the beginning. Maybe have a copy of x86 initially and make modifications for arm64 to it, or move missing code (hotplug, etc.) from x86 to generic and remove x86 arch code with the last patch. -Robert