From: David Brown <david.brown@linaro.org>
To: kernel-hardening@lists.openwall.com
Cc: Ingo Molnar <mingo@redhat.com>, Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@amacapital.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Mathias Krause <minipli@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
PaX Team <pageexec@freemail.hu>, Emese Revfy <re.emese@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [kernel-hardening] [PATCH v4 3/8] param: convert some "on"/"off" users to strtobool
Date: Wed, 27 Jan 2016 14:11:05 -0700 [thread overview]
Message-ID: <20160127211105.GA41450@davidb.org> (raw)
In-Reply-To: <1453226922-16831-4-git-send-email-keescook@chromium.org>
On Tue, Jan 19, 2016 at 10:08:37AM -0800, Kees Cook wrote:
>diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
>index 9cc20af58c76..f5ea98490ffa 100644
>--- a/kernel/time/tick-sched.c
>+++ b/kernel/time/tick-sched.c
>@@ -387,20 +388,14 @@ void __init tick_nohz_init(void)
> /*
> * NO HZ enabled ?
> */
>-static int tick_nohz_enabled __read_mostly = 1;
>+static bool tick_nohz_enabled __read_mostly = true;
> unsigned long tick_nohz_active __read_mostly;
> /*
> * Enable / Disable tickless mode
> */
Just discovered this conflicts with a recent patch with
CONFIG_NO_HZ_COMMON:
commit 46373a15f65fe862f31c19a484acdf551f2b442f
Author: Jean Delvare <jdelvare@suse.de>
Date: Mon Jan 11 17:40:31 2016 +0100
time: nohz: Expose tick_nohz_enabled
kernel/time/tick-sched.c:390:6: error: conflicting types for ‘tick_nohz_enabled’
bool tick_nohz_enabled __read_mostly = true;
^
In file included from kernel/time/tick-internal.h:5:0,
from kernel/time/tick-sched.c:30:
include/linux/tick.h:101:12: note: previous declaration of ‘tick_nohz_enabled’ was here
extern int tick_nohz_enabled;
^
Fixing the compilation error, it compiles and boots on arm64, however
it isn't detecting the write (with the lkdtm test). I'll continue
looking into what's preventing this.
David
next prev parent reply other threads:[~2016-01-27 21:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 18:08 [PATCH v4 0/8] introduce post-init read-only memory Kees Cook
2016-01-19 18:08 ` [PATCH v4 1/8] asm-generic: consolidate mark_rodata_ro() Kees Cook
2016-01-19 18:08 ` [PATCH v4 2/8] lib: add "on" and "off" to strtobool Kees Cook
2016-01-20 2:09 ` Joe Perches
2016-01-22 23:29 ` Kees Cook
2016-01-19 18:08 ` [PATCH v4 3/8] param: convert some "on"/"off" users " Kees Cook
2016-01-27 21:11 ` David Brown [this message]
2016-01-27 21:19 ` [kernel-hardening] " Kees Cook
2016-01-28 0:09 ` [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional David Brown
2016-01-28 0:14 ` Kees Cook
2016-01-28 8:20 ` Ard Biesheuvel
2016-01-28 11:06 ` Mark Rutland
2016-01-28 14:06 ` Kees Cook
2016-01-28 14:59 ` Mark Rutland
2016-01-28 15:17 ` Kees Cook
2016-01-19 18:08 ` [PATCH v4 4/8] init: create cmdline param to disable readonly Kees Cook
2016-01-19 18:08 ` [PATCH v4 5/8] x86: make CONFIG_DEBUG_RODATA non-optional Kees Cook
2016-01-19 18:08 ` [PATCH v4 6/8] introduce post-init read-only memory Kees Cook
2016-01-19 18:08 ` [PATCH v4 7/8] lkdtm: verify that __ro_after_init works correctly Kees Cook
2016-01-19 18:08 ` [PATCH v4 8/8] x86, vdso: mark vDSO read-only after init Kees Cook
2016-01-19 19:09 ` Andy Lutomirski
2016-01-20 2:51 ` H. Peter Anvin
2016-01-20 2:56 ` Andy Lutomirski
2016-01-22 17:19 ` [kernel-hardening] [PATCH v4 0/8] introduce post-init read-only memory David Brown
2016-01-22 19:16 ` Laura Abbott
2016-01-22 19:57 ` Kees Cook
2016-01-23 9:49 ` Geert Uytterhoeven
2016-02-16 21:36 ` [PATCH] ARM: vdso: Mark vDSO code as read-only David Brown
2016-02-16 21:52 ` Kees Cook
2016-02-17 5:20 ` David Brown
2016-02-17 23:00 ` Kees Cook
2016-02-17 23:43 ` David Brown
2016-02-17 23:48 ` Kees Cook
2016-02-18 10:46 ` PaX Team
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127211105.GA41450@davidb.org \
--to=david.brown@linaro.org \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=mpe@ellerman.id.au \
--cc=pageexec@freemail.hu \
--cc=re.emese@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).