Move wlan-ng out of staging?

Move wlan-ng out of staging?

[Ksenija Stanojević]

Hi All,

I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
wlan-ng driver is maybe ready to be moved out of staging. Are there
any TODO tasks left to do beside checkpatch.pl clean-up?

Thanks,
Ksenija

Re: Move wlan-ng out of staging?

[Sudip Mukherjee]

On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
> Hi All,
> 
> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
> wlan-ng driver is maybe ready to be moved out of staging. Are there
> any TODO tasks left to do beside checkpatch.pl clean-up?

I think the main part is still pending. using in-kernel wireless stack.

regards
sudip

Re: Move wlan-ng out of staging?

[Dan Carpenter]

On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
> Hi All,
> 
> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
> wlan-ng driver is maybe ready to be moved out of staging. Are there
> any TODO tasks left to do beside checkpatch.pl clean-up?

I happened to look through this code recently.  It's terrible.

regards,
dan carpenter

Re: Move wlan-ng out of staging?

[Kalle Valo]

Dan Carpenter <dan.carpenter@oracle.com> writes:

> On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
>> Hi All,
>> 
>> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
>> wlan-ng driver is maybe ready to be moved out of staging. Are there
>> any TODO tasks left to do beside checkpatch.pl clean-up?

For questions like this you should CC linux-wireless.

> I happened to look through this code recently.  It's terrible.

And uses wireless extensions, yuck. There's a lot of work to get it into
reasonable shape, fixing checkpatch warnings will not be enough.

-- 
Kalle Valo

Re: Move wlan-ng out of staging?

[Julian Calaby]

Hi Glen,

On Thu, Jan 28, 2016 at 5:27 AM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
>
>> On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
>>> Hi All,
>>>
>>> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
>>> wlan-ng driver is maybe ready to be moved out of staging. Are there
>>> any TODO tasks left to do beside checkpatch.pl clean-up?
>
> For questions like this you should CC linux-wireless.
>
>> I happened to look through this code recently.  It's terrible.
>
> And uses wireless extensions, yuck. There's a lot of work to get it into
> reasonable shape, fixing checkpatch warnings will not be enough.

On the same subject, the wilc1000 driver has taken some pretty big
steps in the past few days, how far away do you think it is from
graduating from staging?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Re: Move wlan-ng out of staging?

[Greg KH]

On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote:
> Hi Glen,
> 
> On Thu, Jan 28, 2016 at 5:27 AM, Kalle Valo <kvalo@codeaurora.org> wrote:
> > Dan Carpenter <dan.carpenter@oracle.com> writes:
> >
> >> On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
> >>> Hi All,
> >>>
> >>> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
> >>> wlan-ng driver is maybe ready to be moved out of staging. Are there
> >>> any TODO tasks left to do beside checkpatch.pl clean-up?
> >
> > For questions like this you should CC linux-wireless.
> >
> >> I happened to look through this code recently.  It's terrible.
> >
> > And uses wireless extensions, yuck. There's a lot of work to get it into
> > reasonable shape, fixing checkpatch warnings will not be enough.
> 
> On the same subject, the wilc1000 driver has taken some pretty big
> steps in the past few days, how far away do you think it is from
> graduating from staging?

I have 221 patches in my to-apply queue to be merged for this driver, at
the very least, those need to be merged before anyone should review it
for graduation.  That number also implies that there is still quite a
lot to be done, but I would not know for sure until that happens.

thanks,

greg k-h

Re: Move wlan-ng out of staging?

[Julian Calaby]

Hi Greg,

On Thu, Jan 28, 2016 at 10:07 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote:
>> Hi Glen,
>>
>> On Thu, Jan 28, 2016 at 5:27 AM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> > Dan Carpenter <dan.carpenter@oracle.com> writes:
>> >
>> >> On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
>> >>> Hi All,
>> >>>
>> >>> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
>> >>> wlan-ng driver is maybe ready to be moved out of staging. Are there
>> >>> any TODO tasks left to do beside checkpatch.pl clean-up?
>> >
>> > For questions like this you should CC linux-wireless.
>> >
>> >> I happened to look through this code recently.  It's terrible.
>> >
>> > And uses wireless extensions, yuck. There's a lot of work to get it into
>> > reasonable shape, fixing checkpatch warnings will not be enough.
>>
>> On the same subject, the wilc1000 driver has taken some pretty big
>> steps in the past few days, how far away do you think it is from
>> graduating from staging?
>
> I have 221 patches in my to-apply queue to be merged for this driver, at
> the very least, those need to be merged before anyone should review it
> for graduation.  That number also implies that there is still quite a
> lot to be done, but I would not know for sure until that happens.

I figured that was the case (there's a _lot_ of churn on that driver)
however I've noticed the patches recently have swung away from being
straight checkpatch / coding style cleanups towards feature additions
and bug fixes, hence my question.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Re: Move wlan-ng out of staging?

[Greg KH]

On Thu, Jan 28, 2016 at 10:28:38AM +1100, Julian Calaby wrote:
> Hi Greg,
> 
> On Thu, Jan 28, 2016 at 10:07 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote:
> >> Hi Glen,
> >>
> >> On Thu, Jan 28, 2016 at 5:27 AM, Kalle Valo <kvalo@codeaurora.org> wrote:
> >> > Dan Carpenter <dan.carpenter@oracle.com> writes:
> >> >
> >> >> On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
> >> >>> Hi All,
> >> >>>
> >> >>> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
> >> >>> wlan-ng driver is maybe ready to be moved out of staging. Are there
> >> >>> any TODO tasks left to do beside checkpatch.pl clean-up?
> >> >
> >> > For questions like this you should CC linux-wireless.
> >> >
> >> >> I happened to look through this code recently.  It's terrible.
> >> >
> >> > And uses wireless extensions, yuck. There's a lot of work to get it into
> >> > reasonable shape, fixing checkpatch warnings will not be enough.
> >>
> >> On the same subject, the wilc1000 driver has taken some pretty big
> >> steps in the past few days, how far away do you think it is from
> >> graduating from staging?
> >
> > I have 221 patches in my to-apply queue to be merged for this driver, at
> > the very least, those need to be merged before anyone should review it
> > for graduation.  That number also implies that there is still quite a
> > lot to be done, but I would not know for sure until that happens.
> 
> I figured that was the case (there's a _lot_ of churn on that driver)
> however I've noticed the patches recently have swung away from being
> straight checkpatch / coding style cleanups towards feature additions
> and bug fixes, hence my question.

Please feel free to audit it and let us know the details :)

Re: Move wlan-ng out of staging?

[Julian Calaby]

Hi Greg,

On Thu, Jan 28, 2016 at 10:32 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Jan 28, 2016 at 10:28:38AM +1100, Julian Calaby wrote:
>> Hi Greg,
>>
>> On Thu, Jan 28, 2016 at 10:07 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote:
>> >> Hi Glen,
>> >>
>> >> On Thu, Jan 28, 2016 at 5:27 AM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> >> > Dan Carpenter <dan.carpenter@oracle.com> writes:
>> >> >
>> >> >> On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
>> >> >>> Hi All,
>> >> >>>
>> >> >>> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
>> >> >>> wlan-ng driver is maybe ready to be moved out of staging. Are there
>> >> >>> any TODO tasks left to do beside checkpatch.pl clean-up?
>> >> >
>> >> > For questions like this you should CC linux-wireless.
>> >> >
>> >> >> I happened to look through this code recently.  It's terrible.
>> >> >
>> >> > And uses wireless extensions, yuck. There's a lot of work to get it into
>> >> > reasonable shape, fixing checkpatch warnings will not be enough.
>> >>
>> >> On the same subject, the wilc1000 driver has taken some pretty big
>> >> steps in the past few days, how far away do you think it is from
>> >> graduating from staging?
>> >
>> > I have 221 patches in my to-apply queue to be merged for this driver, at
>> > the very least, those need to be merged before anyone should review it
>> > for graduation.  That number also implies that there is still quite a
>> > lot to be done, but I would not know for sure until that happens.
>>
>> I figured that was the case (there's a _lot_ of churn on that driver)
>> however I've noticed the patches recently have swung away from being
>> straight checkpatch / coding style cleanups towards feature additions
>> and bug fixes, hence my question.
>
> Please feel free to audit it and let us know the details :)

After looking at the latest round of patches, I take back my comment:
it's not ready.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/