From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966366AbcA1BPX (ORCPT ); Wed, 27 Jan 2016 20:15:23 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:52914 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965598AbcA1BPU (ORCPT ); Wed, 27 Jan 2016 20:15:20 -0500 X-AuditID: cbfee68f-f793a6d000001364-65-56a96ba64079 Date: Thu, 28 Jan 2016 10:15:18 +0900 From: Andi Shyti To: Krzysztof Kozlowski Cc: Chanwoo Choi , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Javier Martinez Canillas , Laxman Dewangan Subject: Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output Message-id: <20160128011518.GD20739@samsunx.samsung> References: <1453877171-30510-1-git-send-email-k.kozlowski@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1453877171-30510-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEIsWRmVeSWpSXmKPExsWyRsSkUHdZ9sowg1v/DSyWXLzKbtFxbTGT xfUvz1kt3rxdw2Tx+oWhxdJ9q1ksLu+aw2axv7OD0YHD48mmi4weeyaeZPPobX7H5rGl/y67 R9+WVYwe0+f9ZPL4vEkugD2KyyYlNSezLLVI3y6BK+PD8T62gtuGFfs/PGRuYLyu1sXIySEh YCIx7X8jK4QtJnHh3nq2LkYuDiGBFYwSDx6/Z4QpmtC2gh0isZRR4mD7PBYI5yOjxKeDG5lB qlgEVCV2vPvEAmKzCWhKNN3+wQZiiwgYShzcvZ0JpIFZYBWTxP+DO8D2CQs4S0z+/xKsiBdo xZuHR5hAbCEBd4nFm3ezQ8QFJX5Mvgc2lFlAS2L9zuNMELa0xKO/M8BqOAU8JI5/6gY6lYND VEBF4tXBepBdEgIv2SVe/V3HCHGcgMS3yYdYQGokBGQlNh1ghvhMUuLgihssExjFZiHZNgvJ tllIti1gZF7FKJpakFxQnJReZKxXnJhbXJqXrpecn7uJERiVp/8969/BePeA9SFGAQ5GJR5e hqiVYUKsiWXFlbmHGE2BrpjILCWanA+M/bySeENjMyMLUxNTYyNzSzMlcd6FUj+DhQTSE0tS s1NTC1KL4otKc1KLDzEycXBKNTA2VNa79XJwfw1r+Guy+t9tjaMsHgyiV/e4ZkoImC218U2e ov7gANvddRrtMaferPSOWHzYuGqBQQKTpVvQnd+d+7fpul7iOz57rf4/0fJeQfXM8j8bnGIv lMQFZBXMOPv/1MX9jfzKLdrr5Lqu7L4u6xfxffnvgo0JqeKVKtYnRR57HXd9XqfEUpyRaKjF XFScCAC3uX+nxQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsVy+t9jAd1l2SvDDD7P07ZYcvEqu0XHtcVM Fte/PGe1ePN2DZPF6xeGFkv3rWaxuLxrDpvF/s4ORgcOjyebLjJ67Jl4ks2jt/kdm8eW/rvs Hn1bVjF6TJ/3k8nj8ya5APaoBkabjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWF vMTcVFslF58AXbfMHKCrlBTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGENYwZ H473sRXcNqzY/+EhcwPjdbUuRk4OCQETiQltK9ghbDGJC/fWs3UxcnEICSxllDjYPo8FwvnI KPHp4EZmkCoWAVWJHe8+sYDYbAKaEk23f7CB2CIChhIHd29nAmlgFljFJPH/4A5WkISwgLPE 5P8vwYp4gda9eXiECcQWEnCXWLx5NztEXFDix+R7YEOZBbQk1u88zgRhS0s8+jsDrIZTwEPi +Kduxi5GDg5RARWJVwfrJzAKzELSPQtJ9ywk3QsYmVcxSqQWJBcUJ6XnGuWllusVJ+YWl+al 6yXn525iBEf+M+kdjId3uR9iFOBgVOLhZYhaGSbEmlhWXJl7iFGCg1lJhHdWMlCINyWxsiq1 KD++qDQntfgQoykwQCYyS4km5wOTUl5JvKGxiZmRpZG5oYWRsbmSOO++S5FhQgLpiSWp2amp BalFMH1MHJxSDYwiyoFhxibmsw0TvvBk1v+XYHNf4lWu1+q46X3q8VMCL3K4/ti+tqz8te6n 0rSK5ac6ZqZbVdWrOLhNPxtymNto8qq3LkU1O94rWtlv4hU1FHj2vaplVvP25ke3Aoq/tZrW 5GuvWLb8Nu+hA57pT363HygTN93OH5/OLunwU7+TcZvSw3fv5ZVYijMSDbWYi4oTAa2PmUUS AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2016 at 03:46:11PM +0900, Krzysztof Kozlowski wrote: > Cleanup of entire driver of its dmesg output: > 1. Remove printing of the function name, because printing device name is > sufficient. This also makes the dev_err()-like functions more compact > and readable (not need of line break). > 2. Lower from info to debug printing of each RTC interrupt (no need to > make noise on each alarm). > 3. Remove dev_info() at beginning of probe because a message is already > always printed by either probe failure or from registering the RTC > device as /dev/rtcX. > > Signed-off-by: Krzysztof Kozlowski Looks good, Reviewed-by: Andi Shyti > --- > > Patch rebased on top of Javier's v4: > [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support > http://www.spinics.net/lists/arm-kernel/msg477194.html > > Feel free to join with these series. > --- > drivers/rtc/rtc-max77686.c | 39 ++++++++++++++------------------------- > 1 file changed, 14 insertions(+), 25 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index da47b1d85793..5a03e1ecad83 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -271,8 +271,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, > info->drv_data->map[REG_RTC_UPDATE0], > data, data); > if (ret < 0) > - dev_err(info->dev, "%s: fail to write update reg(ret=%d, data=0x%x)\n", > - __func__, ret, data); > + dev_err(info->dev, "Fail to write update reg(ret=%d, data=0x%x)\n", > + ret, data); > else { > /* Minimum delay required before RTC update. */ > usleep_range(delay, delay * 2); > @@ -297,7 +297,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm) > info->drv_data->map[REG_RTC_SEC], > data, ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to read time reg(%d)\n", __func__, ret); > + dev_err(info->dev, "Fail to read time reg(%d)\n", ret); > goto out; > } > > @@ -326,8 +326,7 @@ static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm) > info->drv_data->map[REG_RTC_SEC], > data, ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write time reg(%d)\n", __func__, > - ret); > + dev_err(info->dev, "Fail to write time reg(%d)\n", ret); > goto out; > } > > @@ -355,8 +354,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > ret = regmap_bulk_read(info->max77686->rtc_regmap, > map[REG_ALARM1_SEC], data, ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s:%d fail to read alarm reg(%d)\n", > - __func__, __LINE__, ret); > + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); > goto out; > } > > @@ -394,8 +392,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > alrm->pending = 0; > ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS2, &val); > if (ret < 0) { > - dev_err(info->dev, "%s:%d fail to read status2 reg(%d)\n", > - __func__, __LINE__, ret); > + dev_err(info->dev, "Fail to read status2 reg(%d)\n", ret); > goto out; > } > > @@ -426,8 +423,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) > map[REG_ALARM1_SEC], data, > ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); > goto out; > } > > @@ -452,8 +448,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) > } > > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); > goto out; > } > > @@ -481,8 +476,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) > map[REG_ALARM1_SEC], data, > ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); > goto out; > } > > @@ -508,8 +502,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) > } > > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); > goto out; > } > > @@ -539,8 +532,7 @@ static int max77686_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) > data, ARRAY_SIZE(data)); > > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); > goto out; > } > > @@ -575,7 +567,7 @@ static irqreturn_t max77686_rtc_alarm_irq(int irq, void *data) > { > struct max77686_rtc_info *info = data; > > - dev_info(info->dev, "%s:irq(%d)\n", __func__, irq); > + dev_dbg(info->dev, "RTC alarm IRQ: %d\n", irq); > > rtc_update_irq(info->rtc_dev, 1, RTC_IRQF | RTC_AF); > > @@ -605,8 +597,7 @@ static int max77686_rtc_init_reg(struct max77686_rtc_info *info) > info->drv_data->map[REG_RTC_CONTROLM], > data, ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to write controlm reg(%d)\n", ret); > return ret; > } > > @@ -621,8 +612,6 @@ static int max77686_rtc_probe(struct platform_device *pdev) > const struct platform_device_id *id = platform_get_device_id(pdev); > int ret; > > - dev_info(&pdev->dev, "%s\n", __func__); > - > info = devm_kzalloc(&pdev->dev, sizeof(struct max77686_rtc_info), > GFP_KERNEL); > if (!info) > @@ -662,7 +651,7 @@ static int max77686_rtc_probe(struct platform_device *pdev) > > if (!max77686->rtc_irq_data) { > ret = -EINVAL; > - dev_err(&pdev->dev, "%s: no RTC regmap IRQ chip\n", __func__); > + dev_err(&pdev->dev, "No RTC regmap IRQ chip\n"); > goto err_rtc; > } > > -- > 1.9.1