From: Shawn Guo <shawnguo@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: "ohad@wizery.com" <ohad@wizery.com>,
Stefan Agner <stefan@agner.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 3/4] ARM: imx: add the platform related rpmsg implementation
Date: Thu, 28 Jan 2016 13:50:03 +0800 [thread overview]
Message-ID: <20160128055002.GA10671@tiger> (raw)
In-Reply-To: <DBXPR04MB2708826D9E8C16E8EFE492E8CDA0@DBXPR04MB270.eurprd04.prod.outlook.com>
On Thu, Jan 28, 2016 at 02:17:21AM +0000, Richard Zhu wrote:
> > arch/arm/mach-imx/Kconfig | 12 ++
> > arch/arm/mach-imx/Makefile | 2 +
> > arch/arm/mach-imx/imx_rpmsg.c | 364 ++++++++++++++++++++++++++++++++++++++++++
> > arch/arm/mach-imx/mu.c | 217 +++++++++++++++++++++++++
>
> I'm not rpmsg expert, but it seems to me that the driver should be put into drivers/rpmsg/ rather than mach-imx.
> [Richard] This part rpmsg codes are closed related to the platform. For example, kinds of ops callback functions.
> Thus, these codes are placed into arch/arm/mach-imx/ folder. BTW, so does to omap rpmsg implementation.
> http://omappedia.org/wiki/RPMsg_Kernel_Sources
Okay, I will find some time slot to get myself familiar with rpmsg
subsystem and then review the patch.
Shawn
next prev parent reply other threads:[~2016-01-28 5:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 8:06 [RFC 0/4]Enable rpmsg support on imx amp platforms Richard Zhu
2016-01-06 8:06 ` [RFC 1/4] ARM: imx: enable " Richard Zhu
2016-01-06 8:06 ` [RFC 2/4] clk: imx7d: enable the mu and m4 root clocks Richard Zhu
2016-01-06 8:06 ` [RFC 3/4] ARM: imx: add the platform related rpmsg implementation Richard Zhu
2016-01-28 1:35 ` Shawn Guo
2016-01-28 2:17 ` Richard Zhu
2016-01-28 5:50 ` Shawn Guo [this message]
2016-01-28 6:33 ` Richard Zhu
2016-02-15 6:10 ` Shawn Guo
2016-02-15 6:44 ` Richard Zhu
2016-01-06 8:06 ` [RFC 4/4] samples/rpmsg: add the imx pingpong rpmsg sample Richard Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128055002.GA10671@tiger \
--to=shawnguo@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox