From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933179AbcA1FuT (ORCPT ); Thu, 28 Jan 2016 00:50:19 -0500 Received: from mail.kernel.org ([198.145.29.136]:34168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932490AbcA1FuR (ORCPT ); Thu, 28 Jan 2016 00:50:17 -0500 Date: Thu, 28 Jan 2016 13:50:03 +0800 From: Shawn Guo To: Richard Zhu Cc: "ohad@wizery.com" , Stefan Agner , "linux-kernel@vger.kernel.org" Subject: Re: [RFC 3/4] ARM: imx: add the platform related rpmsg implementation Message-ID: <20160128055002.GA10671@tiger> References: <1452067604-10466-1-git-send-email-hongxing.zhu@nxp.com> <1452067604-10466-4-git-send-email-hongxing.zhu@nxp.com> <20160128013527.GA9070@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2016 at 02:17:21AM +0000, Richard Zhu wrote: > > arch/arm/mach-imx/Kconfig | 12 ++ > > arch/arm/mach-imx/Makefile | 2 + > > arch/arm/mach-imx/imx_rpmsg.c | 364 ++++++++++++++++++++++++++++++++++++++++++ > > arch/arm/mach-imx/mu.c | 217 +++++++++++++++++++++++++ > > I'm not rpmsg expert, but it seems to me that the driver should be put into drivers/rpmsg/ rather than mach-imx. > [Richard] This part rpmsg codes are closed related to the platform. For example, kinds of ops callback functions. > Thus, these codes are placed into arch/arm/mach-imx/ folder. BTW, so does to omap rpmsg implementation. > http://omappedia.org/wiki/RPMsg_Kernel_Sources Okay, I will find some time slot to get myself familiar with rpmsg subsystem and then review the patch. Shawn