public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org,
	Paul McKenney <paulmck@linux.vnet.ibm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: [RFC][BUG] tracer: Fails to work
Date: Thu, 28 Jan 2016 09:08:59 +0100	[thread overview]
Message-ID: <20160128080859.GB6357@twins.programming.kicks-ass.net> (raw)

Hi Steve,

So I was hunting wabbits the other day and ftrace failed to work.

After I cursed a bit on IRC, Thomas found the below, after 'fixing' it
like so things worked enough to get the trace out.

Relying on things like this make it entirely impossible to get any trace
data out if you've wedged a CPU. Exactly the kind of situation you want
trace data for.

Please consider an appropriate change to make this happen.

---
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 95181e36891a..b09c5b955555 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -4053,7 +4053,7 @@ EXPORT_SYMBOL_GPL(ring_buffer_read_prepare);
 void
 ring_buffer_read_prepare_sync(void)
 {
-	synchronize_sched();
+//	synchronize_sched();
 }
 EXPORT_SYMBOL_GPL(ring_buffer_read_prepare_sync);
 

             reply	other threads:[~2016-01-28  8:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  8:08 Peter Zijlstra [this message]
2016-01-28 13:38 ` [RFC][BUG] tracer: Fails to work Mathieu Desnoyers
2016-01-28 13:57   ` Peter Zijlstra
2016-01-28 14:18     ` Steven Rostedt
2016-01-28 14:38     ` Mathieu Desnoyers
2016-01-28 14:47       ` Peter Zijlstra
2016-01-28 14:53         ` Mathieu Desnoyers
2016-01-28 15:29           ` Peter Zijlstra
2016-01-28 15:55             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128080859.GB6357@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox