From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966653AbcA1I2r (ORCPT ); Thu, 28 Jan 2016 03:28:47 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36149 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965946AbcA1I2n (ORCPT ); Thu, 28 Jan 2016 03:28:43 -0500 Date: Thu, 28 Jan 2016 13:58:40 +0530 From: Viresh Kumar To: Shilpasri G Bhat Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, linux-pm@vger.kernel.org, pc@us.ibm.com, anton@samba.org, ego@linux.vnet.ibm.com, shreyas@linux.vnet.ibm.com, bsingharora@gmail.com, mpe@ellerman.id.au Subject: Re: [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Message-ID: <20160128082840.GI3935@vireshk> References: <1453965941-7363-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <1453965941-7363-4-git-send-email-shilpa.bhat@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453965941-7363-4-git-send-email-shilpa.bhat@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28-01-16, 12:55, Shilpasri G Bhat wrote: > cpu_to_chip_id() does a DT walk through to find out the chip id by > taking a contended device tree lock. This adds an unnecessary overhead > in a hot path. So instead of calling cpu_to_chip_id() everytime cache > the chip ids for all cores in the array 'core_to_chip_map' and use it > in the hotpath. > > Reported-by: Anton Blanchard > Signed-off-by: Shilpasri G Bhat > --- > Changes from v6: > - Minor changes to move the code 'cpumask_copy()' after 'core_to_chip_map' > is allocated. > - Move 'kfree(chips)' to a separate patch. See, you weren't that bad :) Just that you missed saying that individual patches contain version-log in cover-letter :) Acked-by: Viresh Kumar -- viresh