Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats

Gautham R Shenoy
2016-01-28T08:34:49Z

Hi Shilpa,

A minor nit.
On Thu, Jan 28, 2016 at 12:55:41PM +0530, Shilpasri G Bhat wrote:

[..snip..]
> +
> +What: /sys/devices/system/cpu/cpufreq/chip*/throttle_reasons/<reason_attributes>
> +Date: Jan 2016
> +Contact: Linux kernel mailing list <linux-kernel@vger.kernel.org>
> + Linux for PowerPC mailing list <linuxppc-dev@ozlabs.org>
> +Description: CPU Frequency throttle reason stat for the chip
> +
> + This directory contains throttle reason files. Each file gives
> + the total number of times the max frequency is throttled, except
> + for 'unthrottle_count', which gives the total number of times
> + the max frequency is unthrottled after being throttled. Below
> + are the reason attributes.
> +
> + cpu_over_temperature: Throttled due to cpu over temperature
> +
> + occ_reset: Throttled due to reset of OCC
> +
> + over_current: Throttled due to over current

Overcurrent is a single word. No need of the extra space. You could
fix that and add my Reviewed-by.

--
Thanks and Regards
gautham.