* [patch] drm/vmwgfx: fix a NULL dereference
@ 2016-01-28 9:06 Dan Carpenter
2016-01-28 9:28 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-01-28 9:06 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: Thomas Hellstrom, Alex Deucher, Daniel Stone, Sinclair Yeh,
dri-devel, linux-kernel, kernel-janitors
We dereference "eaction->event" inside the call to drm_send_event_locked()
so should hold off on setting it to NULL until afterward.
Fixes: fb740cf2492c ("drm: Create drm_send_event helpers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
index e0edf14..37c305b 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
@@ -880,8 +880,8 @@ static void vmw_event_fence_action_seq_passed(struct vmw_fence_action *action)
}
list_del_init(&eaction->fpriv_head);
- eaction->event = NULL;
drm_send_event_locked(dev, eaction->event);
+ eaction->event = NULL;
spin_unlock_irqrestore(&dev->event_lock, irq_flags);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] drm/vmwgfx: fix a NULL dereference
2016-01-28 9:06 [patch] drm/vmwgfx: fix a NULL dereference Dan Carpenter
@ 2016-01-28 9:28 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2016-01-28 9:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Daniel Vetter, Thomas Hellstrom, Alex Deucher,
Daniel Stone, Sinclair Yeh, dri-devel, linux-kernel,
kernel-janitors
On Thu, Jan 28, 2016 at 12:06:46PM +0300, Dan Carpenter wrote:
> We dereference "eaction->event" inside the call to drm_send_event_locked()
> so should hold off on setting it to NULL until afterward.
>
> Fixes: fb740cf2492c ("drm: Create drm_send_event helpers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oh dear that's embarassing. Thanks for the patch, applied.
-Daniel
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> index e0edf14..37c305b 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> @@ -880,8 +880,8 @@ static void vmw_event_fence_action_seq_passed(struct vmw_fence_action *action)
> }
>
> list_del_init(&eaction->fpriv_head);
> - eaction->event = NULL;
> drm_send_event_locked(dev, eaction->event);
> + eaction->event = NULL;
> spin_unlock_irqrestore(&dev->event_lock, irq_flags);
> }
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-28 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-28 9:06 [patch] drm/vmwgfx: fix a NULL dereference Dan Carpenter
2016-01-28 9:28 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox