From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755355AbcA1JsJ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jan 2016 04:48:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37447 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755335AbcA1JsF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jan 2016 04:48:05 -0500
Date: Thu, 28 Jan 2016 10:48:02 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
        linux-kernel@vger.kernel.org, eranian@google.com,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into
 printout
Message-ID: <20160128094802.GA13944@krava.brq.redhat.com>
References: <1453256812-24006-1-git-send-email-andi@firstfloor.org>
 <1453256812-24006-4-git-send-email-andi@firstfloor.org>
 <20160122094153.GC27246@krava.brq.redhat.com>
 <20160123034304.GD31686@two.firstfloor.org>
 <20160123161958.GA30110@krava.local>
 <20160126235743.GH31686@two.firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160126235743.GH31686@two.firstfloor.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 27, 2016 at 12:57:43AM +0100, Andi Kleen wrote:
> On Sat, Jan 23, 2016 at 05:19:58PM +0100, Jiri Olsa wrote:
> > On Sat, Jan 23, 2016 at 04:43:05AM +0100, Andi Kleen wrote:
> > > > > -		if (run == 0 || ena == 0) {
> > > > > -			fprintf(output, "CPU%*d%s%*s%s",
> > > > > -				csv_output ? 0 : -4,
> > > > > -				perf_evsel__cpus(counter)->map[cpu], csv_sep,
> > > > > -				csv_output ? 0 : 18,
> > > > > -				counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> > > > > -				csv_sep);
> > > > 
> > > > this hunk is not preserved in the new code.. I guess the output is
> > > > different for -A if counter wasn't meassure?
> > > 
> > > The code for this is common in printout() now.
> > 
> > but what will be printed for -A not counted counters?
> > not the "CPU%*d%s%*s%s" ...
> 
> 
> CPU0       <not supported>      stalled-cycles-backend                                      
> CPU1       <not supported>      stalled-cycles-backend                                      
> CPU2       <not supported>      stalled-cycles-backend                                      
> CPU3       <not supported>      stalled-cycles-backend                                      
> CPU4       <not supported>      stalled-cycles-backend                                      
> CPU5       <not supported>      stalled-cycles-backend                                      
> CPU6       <not supported>      stalled-cycles-backend                                      
> CPU7       <not supported>      stalled-cycles-backend                                      
> CPU8       <not supported>      stalled-cycles-backend                                      
> CPU9       <not supported>      stalled-cycles-backend                                      
> CPU10      <not supported>      stalled-cycles-backend                                      
> CPU11      <not supported>      stalled-cycles-backend                                      

ah the aggr_printout provides that now.. which wasn't
the case for the removed code

thanks,
jirka