From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161229AbcA1LaN (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jan 2016 06:30:13 -0500
Received: from mail-wm0-f41.google.com ([74.125.82.41]:33829 "EHLO
	mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S967331AbcA1LaG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jan 2016 06:30:06 -0500
Date: Thu, 28 Jan 2016 11:30:00 +0000
From: Lee Jones <lee.jones@linaro.org>
To: chenfeng <puck.chen@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
        yudongbin@hisilicon.com, saberlily.xia@hisilicon.com,
        suzhuangluan@hisilicon.com, kong.kongxinwei@hisilicon.com,
        xuyiping@hisilicon.com, z.liuxinliang@hisilicon.com,
        puck.chenfeng@gmail.com, weidong2@hisilicon.com, w.f@huawei.com,
        qijiwen@hisilicon.com, peter.panshilin@hisilicon.com,
        dan.zhao@hisilicon.com, linuxarm@huawei.com, liguozhu@hisilicon.com
Subject: Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver
Message-ID: <20160128113000.GO3368@x1>
References: <1452514817-118311-1-git-send-email-puck.chen@hisilicon.com>
 <1452514817-118311-4-git-send-email-puck.chen@hisilicon.com>
 <20160125142253.GP3368@x1>
 <56A9E405.1080808@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56A9E405.1080808@hisilicon.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 28 Jan 2016, chenfeng wrote:

> Hi Lee,
> 
> Thanks for your review!
> There is one things need your confirm.
> Please help to see it below.
> 
> On 2016/1/25 22:22, Lee Jones wrote:
> > On Mon, 11 Jan 2016, Chen Feng wrote:
> > 
> >> Add pmic mfd driver to support hisilicon hi665x.
> [..]
> 
> > 
> >> +static const struct mfd_cell hi655x_pmic_devs[] = {
> >> +	{ .name = "hi655x-regulator", },
> >> +};
> > 
> > What other devices are there?
> > 
> 
> Current the MFD PMIC driver only has regulator enable.
> 
> The RTC & Power-key are not in these patch sets.
> 
> They will be added later.
> 
> Will this be accepted?

Yes.

> >> +static const struct regmap_irq hi655x_irqs[] = {
> >> +	{ .reg_offset = 0, .mask = OTMP_D1R_INT },
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog