From: Matt Fleming <matt@codeblueprint.co.uk>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Mike Galbraith <mgalbraith@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Make schedstats a runtime tunable that is disabled by default v2
Date: Thu, 28 Jan 2016 11:34:40 +0000 [thread overview]
Message-ID: <20160128113440.GC2571@codeblueprint.co.uk> (raw)
In-Reply-To: <20160128105925.GM3162@techsingularity.net>
On Thu, 28 Jan, at 10:59:25AM, Mel Gorman wrote:
>
> It wasn't really. The patch increased the function size by enough that
> I uninlined it and let the compiler make the decision. In this case,
> it should automatically inline but I can leave the inline in.
Letting the compiler make the decision seems fine to me, but I'll let
other people chime in with their 'static inline' opinions.
My concern was that you didn't intend to delete the keyword, and it
was done by accident. But since that's not the case, it's no big deal.
prev parent reply other threads:[~2016-01-28 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 15:29 [PATCH] sched: Make schedstats a runtime tunable that is disabled by default v2 Mel Gorman
2016-01-27 15:58 ` Mike Galbraith
2016-01-28 10:32 ` Matt Fleming
2016-01-28 10:59 ` Mel Gorman
2016-01-28 11:34 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128113440.GC2571@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mgalbraith@suse.de \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).