From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S967747AbcA1Ler (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jan 2016 06:34:47 -0500
Received: from mail-wm0-f48.google.com ([74.125.82.48]:35536 "EHLO
	mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S967343AbcA1Len (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jan 2016 06:34:43 -0500
Date: Thu, 28 Jan 2016 11:34:40 +0000
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Mike Galbraith <mgalbraith@suse.de>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Make schedstats a runtime tunable that is
 disabled by default v2
Message-ID: <20160128113440.GC2571@codeblueprint.co.uk>
References: <1453908566-15211-1-git-send-email-mgorman@techsingularity.net>
 <20160128103208.GB2571@codeblueprint.co.uk>
 <20160128105925.GM3162@techsingularity.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160128105925.GM3162@techsingularity.net>
User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 28 Jan, at 10:59:25AM, Mel Gorman wrote:
> 
> It wasn't really. The patch increased the function size by enough that
> I uninlined it and let the compiler make the decision. In this case,
> it should automatically inline but I can leave the inline in.

Letting the compiler make the decision seems fine to me, but I'll let
other people chime in with their 'static inline' opinions.

My concern was that you didn't intend to delete the keyword, and it
was done by accident. But since that's not the case, it's no big deal.