From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: "Wang Nan" <wangnan0@huawei.com>,
jolsa@kernel.org, linux-kernel@vger.kernel.org,
"Jérémie Galarneau" <jeremie.galarneau@efficios.com>,
"Zefan Li" <lizefan@huawei.com>,
pi3orama@163.com
Subject: Re: [PATCH v2] perf data: Fix releasing event_class
Date: Thu, 28 Jan 2016 20:42:22 +0100 [thread overview]
Message-ID: <20160128194222.GA12456@krava.brq.redhat.com> (raw)
In-Reply-To: <20160128190930.GA3121@redhat.com>
On Thu, Jan 28, 2016 at 05:09:30PM -0200, Arnaldo Carvalho de Melo wrote:
SNIP
> > however even with this patch I can see perf report getting
> > more memory every time it reloads the data.. either there's
> > something else, or I'm looking at it wrong ;-)
>
> So, for the last delete, IIRC that teardown was removed because it made
> the exit operation to be slower than just not calling
> perf_evlist__delete (or was it perf_session__delete, don't recall right
> now, probably the later, because it would delete all the threads, mmaps,
> etc).
>
> But yeah, for switching perf.data files on the fly, we better free all
> that up...
ook, I'll check some more and queue it in my next post
jirka
prev parent reply other threads:[~2016-01-28 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 11:21 [PATCH] perf data: Fix releasing event_class Wang Nan
2016-01-28 8:59 ` Wangnan (F)
2016-01-28 9:26 ` Jiri Olsa
2016-01-28 13:20 ` [PATCH v2] " Wang Nan
2016-01-28 14:59 ` Jiri Olsa
2016-01-28 19:09 ` Arnaldo Carvalho de Melo
2016-01-28 19:42 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128194222.GA12456@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=jeremie.galarneau@efficios.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox