From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968173AbcA1URA (ORCPT ); Thu, 28 Jan 2016 15:17:00 -0500 Received: from cassarossa.samfundet.no ([193.35.52.29]:46003 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967345AbcA1UQ5 (ORCPT ); Thu, 28 Jan 2016 15:16:57 -0500 Date: Thu, 28 Jan 2016 21:16:49 +0100 From: Hans-Christian Noren Egtvedt To: Jeffrey Merkey Cc: linux-kernel@vger.kernel.org, hskinnemoen@gmail.com, linux.mdb@gmail.com Subject: Re: [PATCH 03/31] Add debugger entry points for AVR32 Message-ID: <20160128201649.GA11179@samfundet.no> References: <1454010377-28501-1-git-send-email-jeffmerkey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454010377-28501-1-git-send-email-jeffmerkey@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Around Thu 28 Jan 2016 12:46:17 -0700 or thereabout, Jeffrey Merkey wrote: > This patch series adds an export which can be set by system debuggers to > direct the hard lockup and soft lockup detector to trigger a breakpoint > exception and enter a debugger if one is active. It is assumed that if > someone sets this variable, then an breakpoint handler of some sort will > be actively loaded or registered via the notify die handler chain. > > This addition is extremely useful for debugging hard and soft lockups > real time and quickly from a console debugger. > > Signed-off-by: Jeffrey Merkey Acked-by: Hans-Christian Egtvedt > --- > arch/avr32/include/asm/kdebug.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/avr32/include/asm/kdebug.h b/arch/avr32/include/asm/kdebug.h > index f930ce2..f67caf0 100644 > --- a/arch/avr32/include/asm/kdebug.h > +++ b/arch/avr32/include/asm/kdebug.h > @@ -1,6 +1,10 @@ > #ifndef __ASM_AVR32_KDEBUG_H > #define __ASM_AVR32_KDEBUG_H > > +static inline void arch_breakpoint(void) > +{ > +} Will not this just be optimized away? Are you expecting other developers to add a no-op assembler instruction into this function body? -- Best regards, Hans-Christian Egtvedt