From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S935258AbcA1Wmh (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jan 2016 17:42:37 -0500
Received: from mail-pf0-f182.google.com ([209.85.192.182]:35813 "EHLO
	mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754640AbcA1Wmc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jan 2016 17:42:32 -0500
Date: Thu, 28 Jan 2016 14:42:25 -0800
From: Andrey Wagin <avagin@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Andy Lutomirski <luto@amacapital.net>,
        Cyrill Gorcunov <gorcunov@openvz.org>, Oleg Nesterov <oleg@redhat.com>,
        "criu@openvz.org" <criu@openvz.org>, kvm@vger.kernel.org
Subject: Re: x86: Hardware breakpoints are not always triggered
Message-ID: <20160128224224.GA10028@gmail.com>
References: <CANaxB-wGTnLX=s9aVG4ziXVtsVn672Q4BmfEX12=398_XZdmqA@mail.gmail.com>
 <56AA8928.50507@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <56AA8928.50507@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 28, 2016 at 10:33:28PM +0100, Paolo Bonzini wrote:
> 
> 
> On 28/01/2016 09:31, Andrey Wagin wrote:
> > I tried to print drX registers after a break-point. Looks like they
> > are set correctly.
> 
> Can you try this KVM patch?

Looks like it fixes a case when reproducers are running only in VM.

If I execute the reproducer a few times on the host and then execute it
in VM, it exits very fast.

Thanks,
Andrew

> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index c13a64b7d789..32bae1c70a50 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -1612,6 +1612,7 @@ static void svm_sync_dirty_debug_regs(struct kvm_vcpu *vcpu)
>  	vcpu->arch.dr7 = svm->vmcb->save.dr7;
>  
>  	vcpu->arch.switch_db_regs &= ~KVM_DEBUGREG_WONT_EXIT;
> +	vcpu->arch.switch_db_regs |= KVM_DEBUGREG_RELOAD;
>  	set_dr_intercepts(svm);
>  }
>  
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index e2951b6edbbc..505a4663b9f4 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -5659,6 +5659,7 @@ static void vmx_sync_dirty_debug_regs(struct kvm_vcpu *vcpu)
>  	vcpu->arch.dr7 = vmcs_readl(GUEST_DR7);
>  
>  	vcpu->arch.switch_db_regs &= ~KVM_DEBUGREG_WONT_EXIT;
> +	vcpu->arch.switch_db_regs |= KVM_DEBUGREG_RELOAD;
>  
>  	cpu_based_vm_exec_control = vmcs_read32(CPU_BASED_VM_EXEC_CONTROL);
>  	cpu_based_vm_exec_control |= CPU_BASED_MOV_DR_EXITING;
> 
> Paolo