From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbcA1XIo (ORCPT ); Thu, 28 Jan 2016 18:08:44 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:36176 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbcA1XIl (ORCPT ); Thu, 28 Jan 2016 18:08:41 -0500 Date: Thu, 28 Jan 2016 15:08:47 -0800 From: Nicolin Chen To: Lothar =?iso-8859-1?Q?Wa=DFmann?= , Mark Brown Cc: Arnd Bergmann , Fabio Estevam , Jaroslav Kysela , Liam Girdwood , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI depending on SoC type Message-ID: <20160128230846.GA32388@Asurada-Nvidia> References: <1453293038-16032-1-git-send-email-LW@KARO-electronics.de> <20160128223352.GB4130@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160128223352.GB4130@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2016 at 11:33:52PM +0100, Mark Brown wrote: > On Wed, Jan 20, 2016 at 01:30:38PM +0100, Lothar Waßmann wrote: > > > - select SND_SOC_FSL_SSI > > + select SND_SOC_FSL_SAI if SOC_IMX6UL > > + select SND_SOC_FSL_SSI if SOC_IMX6Q || SOC_IMX6SL || SOC_IMX6SX > > Does this card not work for older i.MXs (which had the same SSI/AUDMUX > combination as the majority of the i.MX6 family) as well? It's widely used in older i.MXs according to their DTS files. So it should be safer to just leave SSI over here. And I actually doubt the feasibility of running this driver with i.MX6UL as there might not be an AUDMUX on i.MX6UL since it does not have SSI any more while the driver always touches the address space of AUDMUX which may not exist on i.MX6UL.