From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751596AbcA2AQg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jan 2016 19:16:36 -0500
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51329 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751194AbcA2AQc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jan 2016 19:16:32 -0500
Date: Fri, 29 Jan 2016 01:16:03 +0100
From: Mark Brown <broonie@kernel.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Javier Martinez Canillas <javier@dowhile0.org>,
        Lee Jones <lee.jones@linaro.org>, Peter Korsgaard <jacmet@gmail.com>,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Message-ID: <20160129001603.GM4130@sirena.org.uk>
References: <1453863463-30515-1-git-send-email-wenyou.yang@atmel.com>
 <1453863463-30515-2-git-send-email-wenyou.yang@atmel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GeONROBiaq1zPAtT"
Content-Disposition: inline
In-Reply-To: <1453863463-30515-2-git-send-email-wenyou.yang@atmel.com>
X-Cookie: NOBODY EXPECTS THE SPANISH INQUISITION!
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: 109.236.131.45
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for
 ACT8945A
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--GeONROBiaq1zPAtT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 27, 2016 at 10:57:42AM +0800, Wenyou Yang wrote:

> +static const struct of_device_id act8945a_pmic_of_match[] = {
> +	{ .compatible = "active-semi,act8945a-regulator" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, act8945a_pmic_of_match);

This seems mostly OK but why do we have a compatible string here -
shouldn't the MFD be able to instantiate the regulator function without
needing this?

--GeONROBiaq1zPAtT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWqq9BAAoJECTWi3JdVIfQ4vYH/3qOtD2p46jimDLXWmrFSVDV
73raJO0RD5tQrG4WBPXzcEyuuIltS7ntlmcQVzU+3cQSL2FbEUwFKfciG843nFWY
bR0p7jcLuTc49r2HpDgytkC8K81pckjgSDq1HqGGy00u7UKj/v+52ULMOpfqr2Wr
Wd1nJNKL0Qw6HDnjWzyRHKE5HbEQ/UObRhHGOawTy6POhJIOnhOSyDGPP8dCsdCI
lnr3/VSlw+7KXQfziZ/dKuWUz9upcsi9xDw2UFROCUMDMtH1GHSzdPMxTMHh7qGz
D+vqMfOVJzR1UTgPVwvmpftHz7A4i4HT3BPq7VCQda8FtiX/UAzXx4EoUI7MFDQ=
=P57e
-----END PGP SIGNATURE-----

--GeONROBiaq1zPAtT--