From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbcA2DdO (ORCPT ); Thu, 28 Jan 2016 22:33:14 -0500 Received: from mail.kernel.org ([198.145.29.136]:60069 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbcA2DdL (ORCPT ); Thu, 28 Jan 2016 22:33:11 -0500 Date: Thu, 28 Jan 2016 21:33:06 -0600 From: Rob Herring To: dinguyen@opensource.altera.com Cc: ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mark.rutland@arm.com, pawel.moll@arm.com, dinh.linux@gmail.com, andrew@lunn.ch, davem@davemloft.net, f.fainelli@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Doc: Micrel-ksz90x1.txt: Update the Micrel phy documentation for ksz9031 Message-ID: <20160129033306.GA18787@rob-hp-laptop> References: <1453999767-26298-1-git-send-email-dinguyen@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453999767-26298-1-git-send-email-dinguyen@opensource.altera.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2016 at 10:49:27AM -0600, dinguyen@opensource.altera.com wrote: > From: Dinh Nguyen > > Update the Micrel phy documentation for the KSZ9031 PHY to represent how > the actual values are calculated from the code. > > Signed-off-by: Dinh Nguyen > --- > .../devicetree/bindings/net/micrel-ksz90x1.txt | 73 ++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt > index f9c32ad..9535b2b 100644 > --- a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt > +++ b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt > @@ -36,6 +36,71 @@ KSZ9031: > value is 0, and the maximum is property-dependent. The increment > step is 60ps. > > + The KSZ9031 hardware supports a range of skew values from negative to > + positive, where the specific range is property dependent. All values > + specified in the devicetree are offset by the minimum value so they > + can be represented as positive integers in the devicetree since it's > + difficult to represent a negative number in the devictree. I don't think that is true anymore. dtc should allow negative numbers AIUI. That would be much better here. Rob