From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752709AbcA2Gep (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jan 2016 01:34:45 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:34186 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751403AbcA2Geo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jan 2016 01:34:44 -0500
Date: Thu, 28 Jan 2016 22:34:43 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Sanidhya Solanki <jpage.lkml@gmail.com>, devel@driverdev.osuosl.org,
        Jason Cooper <jason@lakedaemon.net>, mathieu.poirier@linaro.org,
        linux-kernel@vger.kernel.org, deepa.kernel@gmail.com,
        vatikaharlalka@gmail.com, brcnakalin@gmail.com
Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to
 header file.
Message-ID: <20160129063443.GA13752@kroah.com>
References: <1449542244-637-1-git-send-email-jpage.lkml@gmail.com>
 <20151208130905.GX6520@io.lakedaemon.net>
 <20151214190808.364f1c9b@gmail.com>
 <20151217071614.GA732@sudip-pc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151217071614.GA732@sudip-pc>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 17, 2015 at 12:46:14PM +0530, Sudip Mukherjee wrote:
> On Mon, Dec 14, 2015 at 07:08:08PM -0500, Sanidhya Solanki wrote:
> > The original code defined macros in the source code, making it
> > harder to read. Moved them to the header file, as per the TODO file.
> > 
> > Updated the TODO file.
> 
> I think the TODO file should not be updated now. There are still some
> macros in skein_block.c.

I agree, it can't be removed just yet, this patch needs to be redone
before I can take it.

thanks,

greg k-h