From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754003AbcA2IV5 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jan 2016 03:21:57 -0500
Received: from mail-wm0-f53.google.com ([74.125.82.53]:36535 "EHLO
	mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753694AbcA2IVx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jan 2016 03:21:53 -0500
Date: Fri, 29 Jan 2016 08:21:48 +0000
From: Lee Jones <lee.jones@linaro.org>
To: Peter Hung <hpeter@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linus.walleij@linaro.org, gnurou@gmail.com, gregkh@linuxfoundation.org,
        paul.gortmaker@windriver.com, jslaby@suse.com,
        peter_hong@fintek.com.tw, heikki.krogerus@linux.intel.com,
        peter@hurleysoftware.com, soeren.grunewald@desy.de, udknight@gmail.com,
        adam.lee@canonical.com, arnd@arndb.de, manabian@gmail.com,
        scottwood@freescale.com, yamada.masahiro@socionext.com,
        paul.burton@imgtec.com, mans@mansr.com, matthias.bgg@gmail.com,
        ralf@linux-mips.org, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
        tom_tsai@fintek.com.tw, Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 1/4] mfd: f81504-core: Add Fintek F81504/508/512
 PCIE-to-UART/GPIO core support
Message-ID: <20160129082148.GR3368@x1>
References: <1453972838-30268-1-git-send-email-hpeter+linux_kernel@gmail.com>
 <1453972838-30268-2-git-send-email-hpeter+linux_kernel@gmail.com>
 <1453982106.2521.279.camel@linux.intel.com>
 <56AAFD88.2060505@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56AAFD88.2060505@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 29 Jan 2016, Peter Hung wrote:
> >>+obj-$(CONFIG_MFD_FINTEK_F81504_CORE)	+= f81504-core.o
> >
> >I think '_' is better than '-'. What I saw and usually do is '_' for
> >regular source modules and '-' for the resulting objects when they have
> >more than one file.
> 
> I used f81504_core.c originally, but I found most of files are named
> xxx-ooo.c when I try to modify makefile. Should I change it to
> f81504_core.c ??

I prefer '-' in MFD.

> >>+#define F81504_DEV_DESC		"Fintek F81504/508/512 PCIE-
> >>to-UART core"
> >
> >Do you need this definition? Is it used more than once?
> 
> ok, I'll direct use the string without define.

Please rid all of the {DEV_NAME,DEV_DEC} defines, they only serve to
obfuscate code.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog