public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov@virtuozzo.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmpressure: Fix subtree pressure detection
Date: Fri, 29 Jan 2016 11:37:49 +0300	[thread overview]
Message-ID: <20160129083749.GB4952@esperanza> (raw)
In-Reply-To: <56AA6AEE.30004@suse.cz>

On Thu, Jan 28, 2016 at 08:24:30PM +0100, Vlastimil Babka wrote:
> On 28.1.2016 16:55, Michal Hocko wrote:
> > On Wed 27-01-16 19:28:57, Vladimir Davydov wrote:
> >> When vmpressure is called for the entire subtree under pressure we
> >> mistakenly use vmpressure->scanned instead of vmpressure->tree_scanned
> >> when checking if vmpressure work is to be scheduled. This results in
> >> suppressing all vmpressure events in the legacy cgroup hierarchy. Fix
> >> it.
> >>
> >> Fixes: 8e8ae645249b ("mm: memcontrol: hook up vmpressure to socket pressure")
> >> Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
> > 
> > a = b += c made me scratch my head for a second but this looks correct
> 
> Ugh, it's actually a = b += a
> 
> While clever and compact, this will make scratch their head anyone looking at
> the code in the future. Is it worth it?

I'm just trying to be consistend with the !tree case, where we do
exactly the same.

Thanks,
Vladimir

  reply	other threads:[~2016-01-29  8:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27 16:28 [PATCH] vmpressure: Fix subtree pressure detection Vladimir Davydov
2016-01-27 18:47 ` Johannes Weiner
2016-01-28 15:55 ` Michal Hocko
2016-01-28 19:24   ` Vlastimil Babka
2016-01-29  8:37     ` Vladimir Davydov [this message]
2016-02-02  6:32       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129083749.GB4952@esperanza \
    --to=vdavydov@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox