From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbcA2LPU (ORCPT ); Fri, 29 Jan 2016 06:15:20 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38323 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbcA2LPS (ORCPT ); Fri, 29 Jan 2016 06:15:18 -0500 Date: Fri, 29 Jan 2016 11:15:14 +0000 From: Lee Jones To: Philipp Zabel Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] mfd: syscon: set regmap max_register in of_syscon_register Message-ID: <20160129111514.GT3368@x1> References: <1454060151-15611-1-git-send-email-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454060151-15611-1-git-send-email-p.zabel@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2016, Philipp Zabel wrote: > Determine the regmap max_register configuration from the io resource size > and the reg-io-width device tree property. > > Signed-off-by: Philipp Zabel > --- > drivers/mfd/syscon.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c > index b730071..2f2225e 100644 > --- a/drivers/mfd/syscon.c > +++ b/drivers/mfd/syscon.c > @@ -50,6 +50,7 @@ static struct syscon *of_syscon_register(struct device_node *np) > u32 reg_io_width; > int ret; > struct regmap_config syscon_config = syscon_regmap_config; > + struct resource res; > > if (!of_device_is_compatible(np, "syscon")) > return ERR_PTR(-EINVAL); > @@ -58,7 +59,12 @@ static struct syscon *of_syscon_register(struct device_node *np) > if (!syscon) > return ERR_PTR(-ENOMEM); > > - base = of_iomap(np, 0); > + if (of_address_to_resource(np, 0, &res)) { > + ret = -ENOMEM; > + goto err_map; > + } > + > + base = ioremap(res.start, resource_size(&res)); > if (!base) { > ret = -ENOMEM; > goto err_map; > @@ -81,6 +87,7 @@ static struct syscon *of_syscon_register(struct device_node *np) > > syscon_config.reg_stride = reg_io_width; > syscon_config.val_bits = reg_io_width * 8; > + syscon_config.max_register = resource_size(&res) - reg_io_width; > > regmap = regmap_init_mmio(NULL, base, &syscon_config); > if (IS_ERR(regmap)) { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog