From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299AbcA2LQw (ORCPT ); Fri, 29 Jan 2016 06:16:52 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38065 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbcA2LQv (ORCPT ); Fri, 29 Jan 2016 06:16:51 -0500 Date: Fri, 29 Jan 2016 11:16:47 +0000 From: Lee Jones To: Philipp Zabel Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] mfd: syscon: make syscon_regmap_config const Message-ID: <20160129111647.GU3368@x1> References: <1454059816-3675-1-git-send-email-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454059816-3675-1-git-send-email-p.zabel@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2016, Philipp Zabel wrote: > syscon_regmap_config can be made const if syscon_probe() creates a local > copy on the stack, just like syscon_register() does. > > Signed-off-by: Philipp Zabel > --- > drivers/mfd/syscon.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c > index b7aabee..b730071 100644 > --- a/drivers/mfd/syscon.c > +++ b/drivers/mfd/syscon.c > @@ -36,7 +36,7 @@ struct syscon { > struct list_head list; > }; > > -static struct regmap_config syscon_regmap_config = { > +static const struct regmap_config syscon_regmap_config = { > .reg_bits = 32, > .val_bits = 32, > .reg_stride = 4, > @@ -192,6 +192,7 @@ static int syscon_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct syscon_platform_data *pdata = dev_get_platdata(dev); > struct syscon *syscon; > + struct regmap_config syscon_config = syscon_regmap_config; > struct resource *res; > void __iomem *base; > > @@ -207,11 +208,10 @@ static int syscon_probe(struct platform_device *pdev) > if (!base) > return -ENOMEM; > > - syscon_regmap_config.max_register = res->end - res->start - 3; > + syscon_config.max_register = res->end - res->start - 3; > if (pdata) > - syscon_regmap_config.name = pdata->label; > - syscon->regmap = devm_regmap_init_mmio(dev, base, > - &syscon_regmap_config); > + syscon_config.name = pdata->label; > + syscon->regmap = devm_regmap_init_mmio(dev, base, &syscon_config); > if (IS_ERR(syscon->regmap)) { > dev_err(dev, "regmap init failed\n"); > return PTR_ERR(syscon->regmap); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog