From: Mark Brown <broonie@kernel.org>
To: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Javier Martinez Canillas <javier@dowhile0.org>,
Lee Jones <lee.jones@linaro.org>,
Peter Korsgaard <jacmet@gmail.com>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A
Date: Fri, 29 Jan 2016 12:35:18 +0100 [thread overview]
Message-ID: <20160129113518.GQ4130@sirena.org.uk> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A243641D63FBF8B@penmbx01>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Fri, Jan 29, 2016 at 01:20:08AM +0000, Yang, Wenyou wrote:
> > > +static const struct of_device_id act8945a_pmic_of_match[] = {
> > > + { .compatible = "active-semi,act8945a-regulator" },
> > > + { },
> > > +};
> > > +MODULE_DEVICE_TABLE(of, act8945a_pmic_of_match);
> > This seems mostly OK but why do we have a compatible string here - shouldn't
> > the MFD be able to instantiate the regulator function without needing this?
> Because I got feedback from Javier for the act8945a-charger patches of this MFD series,
> He said missing the OF match table will cause the module autoloading broken.
> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/398113.html
> What do you think about it?
If then device is not being loaded from the DT (and it shouldn't be, the
device looks like it should be instantiated directly by the MFD as it
can't exist separately to that MFD) an OF table will do nothing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-29 11:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 2:57 [PATCH v4 0/2] regulator: act8945a: add regulator driver for the sub-device of ACT8945A MFD Wenyou Yang
2016-01-27 2:57 ` [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A Wenyou Yang
2016-01-29 0:16 ` Mark Brown
2016-01-29 1:20 ` Yang, Wenyou
2016-01-29 11:35 ` Mark Brown [this message]
2016-01-29 11:50 ` Javier Martinez Canillas
2016-01-29 12:03 ` Mark Brown
2016-02-01 5:54 ` Yang, Wenyou
2016-02-01 13:15 ` Javier Martinez Canillas
2016-02-02 2:26 ` Yang, Wenyou
2016-02-03 2:33 ` Yang, Wenyou
2016-02-03 17:47 ` Mark Brown
2016-02-04 13:28 ` Yang, Wenyou
2016-02-02 17:42 ` Peter Korsgaard
2016-02-03 2:29 ` Yang, Wenyou
2016-02-03 2:45 ` Krzysztof Kozlowski
2016-01-27 2:57 ` [PATCH v4 2/2] regulator: add documentation for ACT8945A's regulator DT bindings Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129113518.GQ4130@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Nicolas.FERRE@atmel.com \
--cc=Wenyou.Yang@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jacmet@gmail.com \
--cc=javier@dowhile0.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox