From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755935AbcA2M6D (ORCPT ); Fri, 29 Jan 2016 07:58:03 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:52716 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbcA2M6A (ORCPT ); Fri, 29 Jan 2016 07:58:00 -0500 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Fri, 29 Jan 2016 13:57:49 +0100 From: Heiko Carstens To: Pratyush Anand , schwidefsky@de.ibm.com, rostedt@goodmis.org, linux-s390@vger.kernel.org, Chunyu Hu , open list Subject: Re: [PATCH] s390:ftrace: add save_stack_trace_regs() Message-ID: <20160129125749.GD3896@osiris> References: <86d380d172bba0416aef64448b0e1b6a50fad326.1454044645.git.panand@redhat.com> <20160129085447.GA3896@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160129085447.GA3896@osiris> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012912-0041-0000-0000-000007192BBA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 09:54:47AM +0100, Heiko Carstens wrote: > On Fri, Jan 29, 2016 at 10:50:28AM +0530, Pratyush Anand wrote: > > Implement save_stack_trace_regs, so that stacktrace of a kprobe events can > > be obtained. > > > > Without this we see following warning: > > "save_stack_trace_regs() not implemented yet." > > when we execute: > > echo stacktrace > /sys/kernel/debug/tracing/trace_options > > echo "p kfree" >> /sys/kernel/debug/tracing/kprobe_events > > echo 1 > /sys/kernel/debug/tracing/events/kprobes/enable > > > > Reported-by: Chunyu Hu > > Signed-off-by: Pratyush Anand > > --- > > Thanks. I just figured out that the ftrace stack tracer doesn't work at all > anymore on s390. I will apply your patch after I fixed that. ;) Surpringly it wasn't one of my own patches which broke the stack tracer on s390, but one from Steven: 72ac426a5bb0 ("tracing: Clean up stack tracing and fix fentry updates") Now I only need to figure out why :)