From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
Cc: gregkh@linuxfoundation.org, christian.gromm@microchip.com,
andrey.shvetsov@k2l.de, adrianremonda@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver
Date: Fri, 29 Jan 2016 23:02:27 +0530 [thread overview]
Message-ID: <20160129173227.GA18826@sudip-laptop> (raw)
In-Reply-To: <BLU436-SMTP23BDE7B8746553D1EA0FFD80DB0@phx.gbl>
On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote:
> From: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
You do not need this From: line here. The email From: header is
sufficient.
>
> Fixes following coading style issues reported by the check patch script.
> - ERROR: Macros with complex values should be enclosed in parentheses
> - CHECK: struct mutex definition without comment
> - CHECK: spinlock_t definition without comment
> - CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code
> rather than BUG() or BUG_ON()
> - WARNING: storage class should be at the beginning of the declaration
You are doing too many things in one patch. Please break them up into
separate patches. Each patch should do only one type of change.
regards
sudip
next parent reply other threads:[~2016-01-29 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BLU436-SMTP23BDE7B8746553D1EA0FFD80DB0@phx.gbl>
2016-01-29 17:32 ` Sudip Mukherjee [this message]
[not found] <BLU437-SMTP51F1BD523F77BFB1E1B51480DB0@phx.gbl>
[not found] ` <BLU185-W57359ACFC388D47D82082680DF0@phx.gbl>
2016-02-03 13:24 ` [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver Dan Carpenter
2016-02-07 22:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129173227.GA18826@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=adrianremonda@gmail.com \
--cc=andrey.shvetsov@k2l.de \
--cc=bijosh.t@hotmail.com \
--cc=christian.gromm@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).