From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756582AbcA2Rcq (ORCPT ); Fri, 29 Jan 2016 12:32:46 -0500 Received: from mail-pa0-f68.google.com ([209.85.220.68]:34634 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753AbcA2Rcp (ORCPT ); Fri, 29 Jan 2016 12:32:45 -0500 Date: Fri, 29 Jan 2016 23:02:27 +0530 From: Sudip Mukherjee To: Bijosh Thykkoottathil Cc: gregkh@linuxfoundation.org, christian.gromm@microchip.com, andrey.shvetsov@k2l.de, adrianremonda@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver Message-ID: <20160129173227.GA18826@sudip-laptop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote: > From: Bijosh Thykkoottathil You do not need this From: line here. The email From: header is sufficient. > > Fixes following coading style issues reported by the check patch script. > - ERROR: Macros with complex values should be enclosed in parentheses > - CHECK: struct mutex definition without comment > - CHECK: spinlock_t definition without comment > - CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code > rather than BUG() or BUG_ON() > - WARNING: storage class should be at the beginning of the declaration You are doing too many things in one patch. Please break them up into separate patches. Each patch should do only one type of change. regards sudip