linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource mapping
Date: Fri, 29 Jan 2016 14:21:08 -0800	[thread overview]
Message-ID: <20160129222108.GA25327@intel.com> (raw)
In-Reply-To: <20160129204826.GA30177@obsidianresearch.com>

On Fri, Jan 29, 2016 at 01:48:27PM -0700, Jason Gunthorpe wrote:
> On Thu, Jan 28, 2016 at 11:13:59PM -0800, Jarkko Sakkinen wrote:
> 
> > -	struct resource tmp = {};
> > -
> > -	tmp.start = start;
> > -	tmp.end = start + size - 1;
> > -	tmp.flags = IORESOURCE_MEM;
> > +	struct resource new_res = {
> > +		.start	= start,
> > +		.end	= size - 1,
> 
> That isn't right.

Whoops. Good catch, I'll update it before pull request. Thanks!

> Jason

/Jarkko

  reply	other threads:[~2016-01-29 22:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29  7:13 [PATCH] tpm, tpm_crb: fix control area resource mapping Jarkko Sakkinen
2016-01-29 20:48 ` [tpmdd-devel] " Jason Gunthorpe
2016-01-29 22:21   ` Jarkko Sakkinen [this message]
2016-01-29 22:26     ` Jarkko Sakkinen
2016-01-29 22:33       ` Jason Gunthorpe
2016-01-29 22:39         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129222108.GA25327@intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).