From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbcA2WVK (ORCPT ); Fri, 29 Jan 2016 17:21:10 -0500 Received: from mga14.intel.com ([192.55.52.115]:15300 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbcA2WVJ (ORCPT ); Fri, 29 Jan 2016 17:21:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,366,1449561600"; d="scan'208";a="872044074" Date: Fri, 29 Jan 2016 14:21:08 -0800 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource mapping Message-ID: <20160129222108.GA25327@intel.com> References: <1454051639-15961-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160129204826.GA30177@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160129204826.GA30177@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 01:48:27PM -0700, Jason Gunthorpe wrote: > On Thu, Jan 28, 2016 at 11:13:59PM -0800, Jarkko Sakkinen wrote: > > > - struct resource tmp = {}; > > - > > - tmp.start = start; > > - tmp.end = start + size - 1; > > - tmp.flags = IORESOURCE_MEM; > > + struct resource new_res = { > > + .start = start, > > + .end = size - 1, > > That isn't right. Whoops. Good catch, I'll update it before pull request. Thanks! > Jason /Jarkko