From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753947AbcA2WqD (ORCPT ); Fri, 29 Jan 2016 17:46:03 -0500 Received: from mga01.intel.com ([192.55.52.88]:24298 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839AbcA2WqB (ORCPT ); Fri, 29 Jan 2016 17:46:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,366,1449561600"; d="scan'208";a="892165622" Date: Fri, 29 Jan 2016 17:45:56 -0500 From: Matthew Wilcox To: Dan Williams Cc: linux-block@vger.kernel.org, linux-nvdimm@ml01.01.org, Dave Chinner , linux-kernel@vger.kernel.org, Christoph Hellwig , axboe@fb.com, Jeff Moyer , Jan Kara , linux-fsdevel@vger.kernel.org, Andrew Morton , Ross Zwisler Subject: Re: [PATCH 2/2] block: use DAX for partition table reads Message-ID: <20160129224556.GX2948@linux.intel.com> References: <20160129151835.18752.9423.stgit@dwillia2-desk3.amr.corp.intel.com> <20160129151846.18752.48460.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160129151846.18752.48460.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 07:18:46AM -0800, Dan Williams wrote: > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 29189aeace19..b1452c04f1a9 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1633,6 +1633,16 @@ struct blk_dax_ctl { > pfn_t pfn; > }; > > +#ifdef CONFIG_FS_DAX > +struct page *read_dax_sector(struct block_device *bdev, sector_t n); > +#else > +static inline struct page *read_dax_sector(struct block_device *bdev, > + sector_t n) > +{ > + return ERR_PTR(-ENXIO); > +} > +#endif > + Can you move this to include/linux/dax.h? I'd like to keep it that all functions in dax.c have a prototype in dax.h. With that change, Reviewed-by: Matthew Wilcox