From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756742AbcA3AeI (ORCPT ); Fri, 29 Jan 2016 19:34:08 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36445 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756625AbcA3AeG (ORCPT ); Fri, 29 Jan 2016 19:34:06 -0500 Date: Fri, 29 Jan 2016 16:34:04 -0800 From: Stephen Boyd To: Andi Shyti Cc: linux-samsung-soc@vger.kernel.org, Sangbeom Kim , Krzysztof Kozlowski , Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Andi Shyti , Yadwinder Singh Brar , Jaehoon Chung Subject: Re: [PATCH v3 2/4] clk: s2mps11: allocate only one structure for clock init Message-ID: <20160130003404.GI12841@codeaurora.org> References: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com> <1453284864-8082-3-git-send-email-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453284864-8082-3-git-send-email-andi.shyti@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20, Andi Shyti wrote: > The driver allocates three structures, s2mpsxx_clk_init, for > three different clock types (s2mps11, s2mps13 and s2mps14). They > are quite similar but they differ only by the name. Only one of > these structures is used, while the others lie unused in the > memory. > > The clock's name, though, is not such a meaningful information > and by assigning the same name to the initial data we can avoid > over allocation. The common name chosen will be s2mps11, > coherently with the device driver name, instead of the clock > device. > > Therefore, remove the structures associated to s2mps13 and > s2mps14 and use only the one referred to s2mps11 for all kind of > clocks. > > Signed-off-by: Andi Shyti > Suggested-by: Krzysztof Kozlowski > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project