From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753710AbcA3J1v (ORCPT ); Sat, 30 Jan 2016 04:27:51 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35869 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752278AbcA3J1s (ORCPT ); Sat, 30 Jan 2016 04:27:48 -0500 Date: Sat, 30 Jan 2016 10:27:43 +0100 From: Ingo Molnar To: Byungchul Park Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, akinobu.mita@gmail.com, jack@suse.cz, sergey.senozhatsky.work@gmail.com, peter@hurleysoftware.com, torvalds@linux-foundation.org Subject: Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in the debug code Message-ID: <20160130092743.GA13745@gmail.com> References: <1454071417-20685-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454071417-20685-1-git-send-email-byungchul.park@lge.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Byungchul Park wrote: > + > + /* > + * If this function is called from printk(), then we should > + * not call printk() more. Or it will cause an infinite > + * recursive cycle! This should be something like: > + * If this function is called from within printk() then we > + * should not call printk() again, or it will recurse > + * infinitely. Thanks, Ingo