From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756789AbcA3Jbe (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 Jan 2016 04:31:34 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:36310 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754156AbcA3Jb3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 Jan 2016 04:31:29 -0500
Date: Sat, 30 Jan 2016 10:31:24 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Brian Gerst <brgerst@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
        "linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>,
        tip-bot for Andy Lutomirski <tipbot@zytor.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>
Subject: Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and
 __SYSCALL_X32
Message-ID: <20160130093124.GA14301@gmail.com>
References: <58d4a95f40e43b894f93288b4a3633963d0ee22e.1454022279.git.luto@kernel.org>
 <tip-32324ce15ea8cb4c8acc28acb2fd36fabf73e9db@git.kernel.org>
 <726983A1-F3A9-476B-AAA2-871F0561CB47@zytor.com>
 <CAMzpN2jqx4z0d+53cQiG3xU93tNRH+HV_+ZLyaMFXMk+fapzgA@mail.gmail.com>
 <CALCETrWJarxEuH4_hjPzrQ4Uf+bFqy1jf=96VoezRznAy9OAAQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrWJarxEuH4_hjPzrQ4Uf+bFqy1jf=96VoezRznAy9OAAQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andy Lutomirski <luto@amacapital.net> wrote:

> >>>+      if [ "$abi" == "COMMON" -o "$abi" == "64" ]; then
> >>>+          # COMMON is the same as 64, except that we don't expect X32
> >>>+          # programs to use it.  Our expectation has nothing to do with
> >>>+          # any generated code, so treat them the same.
> >>>+          emit 64 "$nr" "$entry" "$compat"
> >>>+      elif [ "$abi" == "X32" ]; then
> >>>+          # X32 is equivalent to 64 on an X32-compatible kernel.
> >>>+          echo "#ifdef CONFIG_X86_X32_ABI"
> >>>+          emit 64 "$nr" "$entry" "$compat"
> >>>+          echo "#endif"
> >>>+      elif [ "$abi" == "I386" ]; then
> >>>+          emit "$abi" "$nr" "$entry" "$compat"
> >>>+      else
> >>>+          echo "Unknown abi $abi" >&2
> >>>+          exit 1
> >>>+      fi

> No combinatorial explosion, please.  We could use __SYSCALL(nr, sym,
> abi, qual), though.

Mind fixing it, so that we get back the arch-neutral property?

Thanks,

	Ingo