Re: [PATCH 1/4] Add support for new platform, X51-R3

[Darren Hart <dvhart@infradead.org>]

On Thu, Jan 21, 2016 at 06:04:57PM -0600, Mario Limonciello wrote:

Hi Mario,

Thank you for patch submission.

Please remember to always include a commit message body describing your patch in
more detail than the single line subject. It should provide enough detail to get
someone unfamiliar with these changes to understand why they were needed  and
how you intended to go about fixing it. This is the context needed to review the
patch.

In addition to adding X51 R3 as a separate platform from the previous X51 Family
(no R1 R2), this patch also appears to introduce various whitespace changes. Any
change made within the patch should read back to some comment in the changelog.

> Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
> ---
>  drivers/platform/x86/alienware-wmi.c | 44 ++++++++++++++++++++++++------------
>  1 file changed, 29 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c
> index 1e1e594..dcd4f81 100644
> --- a/drivers/platform/x86/alienware-wmi.c
> +++ b/drivers/platform/x86/alienware-wmi.c
> @@ -69,11 +69,16 @@ static struct quirk_entry quirk_unknown = {
>  	.hdmi_mux = 0,
>  };
>  
> -static struct quirk_entry quirk_x51_family = {
> +static struct quirk_entry quirk_x51_r1_r2 = {
>  	.num_zones = 3,
>  	.hdmi_mux = 0.
>  };
>  
> +static struct quirk_entry quirk_x51_r3 = {
> +	.num_zones = 4,
> +	.hdmi_mux = 0,
> +};
> +
>  static struct quirk_entry quirk_asm100 = {
>  	.num_zones = 2,
>  	.hdmi_mux = 1,
> @@ -88,12 +93,12 @@ static int __init dmi_matched(const struct dmi_system_id *dmi)
>  static const struct dmi_system_id alienware_quirks[] __initconst = {
>  	{
>  	 .callback = dmi_matched,
> -	 .ident = "Alienware X51 R1",
> +	 .ident = "Alienware X51 R3",
>  	 .matches = {
>  		     DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> -		     DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51"),
> +		     DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51 R3"),
>  		     },
> -	 .driver_data = &quirk_x51_family,
> +	 .driver_data = &quirk_x51_r3,
>  	 },
>  	{
>  	 .callback = dmi_matched,
> @@ -102,17 +107,26 @@ static const struct dmi_system_id alienware_quirks[] __initconst = {
>  		     DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
>  		     DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51 R2"),
>  		     },
> -	 .driver_data = &quirk_x51_family,
> +	 .driver_data = &quirk_x51_r1_r2,
> +	 },
> +	{
> +	 .callback = dmi_matched,
> +	 .ident = "Alienware X51 R1",
> +	 .matches = {
> +		     DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> +		     DMI_MATCH(DMI_PRODUCT_NAME, "Alienware X51"),
> +		     },
> +	 .driver_data = &quirk_x51_r1_r2,
>  	 },
>  	{
> -		.callback = dmi_matched,
> -		.ident = "Alienware ASM100",
> -		.matches = {
> -			DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> -			DMI_MATCH(DMI_PRODUCT_NAME, "ASM100"),
> -		},
> -		.driver_data = &quirk_asm100,
> -	},
> +	 .callback = dmi_matched,
> +	 .ident = "Alienware ASM100",
> +	 .matches = {
> +		     DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> +		     DMI_MATCH(DMI_PRODUCT_NAME, "ASM100"),
> +		     },
> +	 .driver_data = &quirk_asm100,
> +	 },
>  	{}
>  };
>  
> @@ -477,7 +491,7 @@ static ssize_t show_hdmi_cable(struct device *dev,
>  	};
>  	status =
>  	    alienware_hdmi_command(&in_args, WMAX_METHOD_HDMI_CABLE,
> -				   (u32 *) &out_data);
> +				   (u32 *) & out_data);
>  	if (ACPI_SUCCESS(status)) {
>  		if (out_data == 0)
>  			return scnprintf(buf, PAGE_SIZE,
> @@ -500,7 +514,7 @@ static ssize_t show_hdmi_source(struct device *dev,
>  	};
>  	status =
>  	    alienware_hdmi_command(&in_args, WMAX_METHOD_HDMI_STATUS,
> -				   (u32 *) &out_data);
> +				   (u32 *) & out_data);
>  
>  	if (ACPI_SUCCESS(status)) {
>  		if (out_data == 1)
> -- 
> 1.9.1
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center