From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932820AbcA3Rkg (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 Jan 2016 12:40:36 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:35827 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932215AbcA3Rkf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 Jan 2016 12:40:35 -0500
Date: Sat, 30 Jan 2016 18:40:30 +0100
From: Mathieu OTHACEHE <m.othacehe@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial
 private data
Message-ID: <20160130174030.GA16025@gmail.com>
References: <1451933379-21994-1-git-send-email-m.othacehe@gmail.com>
 <1451933379-21994-2-git-send-email-m.othacehe@gmail.com>
 <20160125120159.GI3163@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160125120159.GI3163@localhost>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 25, 2016 at 01:01:59PM +0100, Johan Hovold wrote:
> On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote:
> > On nominal execution, private data allocated on port_probe and attach
> > are never freed. Add port_remove and release callbacks to free them
> > respectively.
> > 
> > Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
> 
> I've applied this one for 4.5-rc2 now.
> 
> I want to take a closer look at the last three patches and it seems they
> should wait for 4.6 anyway. I did notice that the vendor driver also
> sends double START/OPEN commands at open by the way. Perhaps ask Moxa
> why that is before we remove them?
> 
> Thanks,
> Johan

Hi Johan,

I asked MOXA about this double opening. I also noticed that the
mainline driver ti_usb_3410_5052 uses the same double opening pattern.
And, MOXA UPORT 11x0 serie is based on TUSB3410 chip of TI.

So, I also emailed TI, and the authors of ti_usb_3410_5052 driver.

I keep you informed,

Thank you

Mathieu