From: Jarod Wilson <jarod@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, edumazet@google.com,
jiri@mellanox.com, daniel@iogearbox.net, tom@herbertland.com,
j.vosburgh@gmail.com, vfalico@gmail.com,
gospo@cumulusnetworks.com, netdev@vger.kernel.org
Subject: Re: [PATCH net v2 0/4] net: add and use rx_nohandler stat counter
Date: Sat, 30 Jan 2016 13:16:48 -0500 [thread overview]
Message-ID: <20160130181648.GP59058@redhat.com> (raw)
In-Reply-To: <20160129.193751.27856238718097733.davem@davemloft.net>
On Fri, Jan 29, 2016 at 07:37:51PM -0800, David Miller wrote:
> From: Jarod Wilson <jarod@redhat.com>
> Date: Thu, 28 Jan 2016 10:49:44 -0500
>
> > The network core tries to keep track of dropped packets, but some packets
> > you wouldn't really call dropped, so much as intentionally ignored, under
> > certain circumstances. One such case is that of bonding and team device
> > slaves that are currently inactive. Their respective rx_handler functions
> > return RX_HANDLER_EXACT (the only places in the kernel that return that),
> > which ends up tracking into the network core's __netif_receive_skb_core()
> > function's drop path, with no pt_prev set. On a noisy network, this can
> > result in a very rapidly incrementing rx_dropped counter, not only on the
> > inactive slave(s), but also on the master device, such as the following:
> ...
>
> Both my inbox and patchwork only show patch 2, 3, and 4. Where is #1?
Crap. It seems I fat-fingered netdev@vger.kernel.org without the v in
front of ger. Will re-send in a sec, hopefully finallly not screwing it up
this time.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2016-01-30 18:16 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 19:11 [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves Jarod Wilson
2016-01-22 20:59 ` Jay Vosburgh
2016-01-23 8:26 ` Jiri Pirko
2016-01-23 8:07 ` Jiri Pirko
2016-01-23 14:19 ` Andy Gospodarek
2016-01-23 15:23 ` Eric Dumazet
2016-01-26 21:14 ` Jarod Wilson
2016-01-26 21:21 ` David Miller
2016-01-26 21:36 ` Jarod Wilson
2016-01-26 21:24 ` Eric Dumazet
2016-01-26 21:35 ` Jarod Wilson
2016-01-25 6:42 ` David Miller
2016-01-25 14:27 ` Jarod Wilson
2016-01-26 4:45 ` Jarod Wilson
2016-01-27 20:21 ` [PATCH net 0/4] net: add rx_unhandled stat counter Jarod Wilson
2016-01-27 20:21 ` [PATCH net 1/4] " Jarod Wilson
2016-01-27 20:21 ` [PATCH net 2/4] net-procfs: show rx_unhandled counters Jarod Wilson
2016-01-27 20:21 ` [PATCH net 3/4] team: track sum of rx_unhandled for all slaves Jarod Wilson
2016-01-27 20:21 ` [PATCH net 4/4] bond: " Jarod Wilson
2016-01-27 21:09 ` [PATCH net 0/4] net: add rx_unhandled stat counter Eric Dumazet
2016-01-28 6:02 ` Jarod Wilson
2016-01-28 6:10 ` Jarod Wilson
2016-01-28 6:18 ` Jarod Wilson
2016-01-28 13:00 ` Eric Dumazet
2016-01-28 14:38 ` Jarod Wilson
2016-01-28 14:42 ` Eric Dumazet
2016-01-28 14:44 ` Eric Dumazet
2016-01-28 14:46 ` Eric Dumazet
2016-01-28 15:11 ` Jarod Wilson
2016-01-28 13:00 ` Eric Dumazet
2016-01-28 15:49 ` [PATCH net v2 0/4] net: add and use rx_nohandler " Jarod Wilson
2016-01-28 15:49 ` [PATCH net v2 1/4] net/core: relax BUILD_BUG_ON in netdev_stats_to_stats64 Jarod Wilson
2016-01-28 15:49 ` [PATCH net v2 2/4] net: add rx_nohandler stat counter Jarod Wilson
2016-01-28 15:49 ` [PATCH net v2 3/4] team: track sum of rx_nohandler for all slaves Jarod Wilson
2016-01-28 15:49 ` [PATCH net v2 4/4] bond: " Jarod Wilson
2016-01-30 3:37 ` [PATCH net v2 0/4] net: add and use rx_nohandler stat counter David Miller
2016-01-30 18:16 ` Jarod Wilson [this message]
2016-01-30 18:19 ` [PATCH net v2 1/4] net/core: relax BUILD_BUG_ON in netdev_stats_to_stats64 Jarod Wilson
2016-01-30 18:34 ` Eric Dumazet
2016-01-30 20:39 ` Jarod Wilson
2016-01-30 20:53 ` Jarod Wilson
2016-01-30 23:26 ` David Miller
2016-01-31 18:07 ` Jarod Wilson
2016-02-01 23:51 ` [PATCH net v3 0/4] net: add and use rx_nohandler stat counter Jarod Wilson
2016-02-01 23:51 ` [PATCH net v3 1/4] net/core: relax BUILD_BUG_ON in netdev_stats_to_stats64 Jarod Wilson
2016-02-01 23:51 ` [PATCH net v3 2/4] net: add rx_nohandler stat counter Jarod Wilson
2016-02-07 19:37 ` Stephen Hemminger
2016-02-07 19:46 ` David Miller
2016-02-07 20:19 ` Eric Dumazet
2016-02-08 18:32 ` Jarod Wilson
2016-02-08 19:38 ` Stephen Hemminger
2016-02-08 22:57 ` Eric Dumazet
2016-02-09 8:40 ` David Miller
2016-02-09 10:56 ` Jamal Hadi Salim
2016-02-09 19:17 ` [PATCH net-next iproute2] iplink: display rx nohandler stats Stephen Hemminger
2016-02-09 23:51 ` Jarod Wilson
2016-02-10 1:41 ` Stephen Hemminger
2016-02-10 4:52 ` Eric Dumazet
2016-02-10 13:20 ` Jarod Wilson
2016-02-10 15:06 ` Andy Gospodarek
2016-02-01 23:51 ` [PATCH net v3 3/4] team: track sum of rx_nohandler for all slaves Jarod Wilson
2016-02-01 23:51 ` [PATCH net v3 4/4] bond: " Jarod Wilson
2016-02-06 8:00 ` [PATCH net v3 0/4] net: add and use rx_nohandler stat counter David Miller
2016-01-28 16:22 ` [PATCH net v3 1/4] net/core: relax BUILD_BUG_ON in netdev_stats_to_stats64 Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160130181648.GP59058@redhat.com \
--to=jarod@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).