From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933531AbcAaUJf (ORCPT ); Sun, 31 Jan 2016 15:09:35 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36123 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497AbcAaUJT (ORCPT ); Sun, 31 Jan 2016 15:09:19 -0500 X-Google-Original-Sender: Date: Sun, 31 Jan 2016 21:10:21 +0100 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 00/14] USB: serial: Fix coccinelle warnings Message-ID: <20160131201021.GD2957@localhost> References: <1454175887-16158-1-git-send-email-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454175887-16158-1-git-send-email-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 30, 2016 at 06:44:33PM +0100, Mathieu OTHACEHE wrote: > This series of patches fixes all coccinelle warnings in > USB serial subsystem > > Mathieu OTHACEHE (14): > USB: serial: safe_serial: fix assignment of bool to 0/1 > USB: serial: safe_serial: fix assignment of bool to non 0/1 constant > USB: serial: quatech2: remove comparison to bool > USB: serial: iuu_phoenix: remove comparison of bool > USB: serial: mos7840: remove comparison to bool > USB: serial: garmin_gps: move constants to right > USB: serial: ftdi_sio: move constants to right > USB: serial: keyspan: remove unused semicolon > USB: serial: cyberjack: remove unneeded variable > USB: serial: garmin_gps: remove unneeded variable > USB: serial: mos7840: move constants to right > USB: serial: ch341: move constants to right > USB: serial: f81232: move constants to right > USB: serial: kl5kusb105: remove unneeded semicolons Please squash these per type (or larger class) of issue you're fixing, at least when the diffs aren't too big. No need to remove two semicolons in two patches, etc. Thanks, Johan