* [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
@ 2016-02-01 5:22 Byeoungwook Kim
0 siblings, 0 replies; 6+ messages in thread
From: Byeoungwook Kim @ 2016-02-01 5:22 UTC (permalink / raw)
To: gregkh; +Cc: ksenija.stanojevic, quddnr145, luisbg, devel, linux-kernel
clean up checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Byeoungwook Kim <quddnr145@gmail.com>
---
drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++-----------------
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 4911fef..f828e64 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -1,21 +1,23 @@
-/*
- This file contains wireless extension handlers.
-
- This is part of rtl8180 OpenSource driver.
- Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
- Released under the terms of GPL (General Public Licence)
-
- Parts of this driver are based on the GPL part
- of the official realtek driver.
-
- Parts of this driver are based on the rtl8180 driver skeleton
- from Patric Schenke & Andres Salomon.
-
- Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
-
- We want to thank the Authors of those projects and the Ndiswrapper
- project Authors.
-*/
+/******************************************************************************
+ *
+ * This file contains wireless extension handlers.
+ *
+ * This is part of rtl8180 OpenSource driver.
+ * Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
+ * Released under the terms of GPL (General Public Licence)
+ *
+ * Parts of this driver are based on the GPL part
+ * of the official realtek driver.
+ *
+ * Parts of this driver are based on the rtl8180 driver skeleton
+ * from Patric Schenke & Andres Salomon.
+ *
+ * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
+ *
+ * We want to thank the Authors of those projects and the Ndiswrapper
+ * project Authors.
+ *
+ *****************************************************************************/
#include <linux/string.h>
#include "r8192U.h"
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
@ 2016-02-01 5:35 Byeoungwook Kim
0 siblings, 0 replies; 6+ messages in thread
From: Byeoungwook Kim @ 2016-02-01 5:35 UTC (permalink / raw)
To: gregkh; +Cc: ksenija.stanojevic, luisbg, devel, linux-kernel
clean up checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Byeoungwook Kim <quddnr145@gmail.com>
---
drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++-----------------
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 4911fef..f828e64 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -1,21 +1,23 @@
-/*
- This file contains wireless extension handlers.
-
- This is part of rtl8180 OpenSource driver.
- Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
- Released under the terms of GPL (General Public Licence)
-
- Parts of this driver are based on the GPL part
- of the official realtek driver.
-
- Parts of this driver are based on the rtl8180 driver skeleton
- from Patric Schenke & Andres Salomon.
-
- Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
-
- We want to thank the Authors of those projects and the Ndiswrapper
- project Authors.
-*/
+/******************************************************************************
+ *
+ * This file contains wireless extension handlers.
+ *
+ * This is part of rtl8180 OpenSource driver.
+ * Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
+ * Released under the terms of GPL (General Public Licence)
+ *
+ * Parts of this driver are based on the GPL part
+ * of the official realtek driver.
+ *
+ * Parts of this driver are based on the rtl8180 driver skeleton
+ * from Patric Schenke & Andres Salomon.
+ *
+ * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
+ *
+ * We want to thank the Authors of those projects and the Ndiswrapper
+ * project Authors.
+ *
+ *****************************************************************************/
#include <linux/string.h>
#include "r8192U.h"
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
@ 2016-02-01 5:16 Byeoungwook Kim
2016-02-01 7:01 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Byeoungwook Kim @ 2016-02-01 5:16 UTC (permalink / raw)
To: gregkh; +Cc: ksenija.stanojevic, luisbg, devel, linux-kernel, kernel-janitors
clean up checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Byeoungwook Kim <quddnr145@gmail.com>
---
drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++-----------------
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 4911fef..f828e64 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -1,21 +1,23 @@
-/*
- This file contains wireless extension handlers.
-
- This is part of rtl8180 OpenSource driver.
- Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
- Released under the terms of GPL (General Public Licence)
-
- Parts of this driver are based on the GPL part
- of the official realtek driver.
-
- Parts of this driver are based on the rtl8180 driver skeleton
- from Patric Schenke & Andres Salomon.
-
- Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
-
- We want to thank the Authors of those projects and the Ndiswrapper
- project Authors.
-*/
+/******************************************************************************
+ *
+ * This file contains wireless extension handlers.
+ *
+ * This is part of rtl8180 OpenSource driver.
+ * Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
+ * Released under the terms of GPL (General Public Licence)
+ *
+ * Parts of this driver are based on the GPL part
+ * of the official realtek driver.
+ *
+ * Parts of this driver are based on the rtl8180 driver skeleton
+ * from Patric Schenke & Andres Salomon.
+ *
+ * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
+ *
+ * We want to thank the Authors of those projects and the Ndiswrapper
+ * project Authors.
+ *
+ *****************************************************************************/
#include <linux/string.h>
#include "r8192U.h"
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
2016-02-01 5:16 Byeoungwook Kim
@ 2016-02-01 7:01 ` Julia Lawall
2016-02-01 7:31 ` ByeoungWook Kim
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2016-02-01 7:01 UTC (permalink / raw)
To: Byeoungwook Kim
Cc: gregkh, ksenija.stanojevic, luisbg, devel, linux-kernel,
kernel-janitors
On Mon, 1 Feb 2016, Byeoungwook Kim wrote:
> clean up checkpatch warning:
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Byeoungwook Kim <quddnr145@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++-----------------
> 1 file changed, 20 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 4911fef..f828e64 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -1,21 +1,23 @@
> -/*
> - This file contains wireless extension handlers.
> -
> - This is part of rtl8180 OpenSource driver.
> - Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
> - Released under the terms of GPL (General Public Licence)
> -
> - Parts of this driver are based on the GPL part
> - of the official realtek driver.
> -
> - Parts of this driver are based on the rtl8180 driver skeleton
> - from Patric Schenke & Andres Salomon.
> -
> - Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
> -
> - We want to thank the Authors of those projects and the Ndiswrapper
> - project Authors.
> -*/
> +/******************************************************************************
Is the row of *s needed?
julia
> + *
> + * This file contains wireless extension handlers.
> + *
> + * This is part of rtl8180 OpenSource driver.
> + * Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
> + * Released under the terms of GPL (General Public Licence)
> + *
> + * Parts of this driver are based on the GPL part
> + * of the official realtek driver.
> + *
> + * Parts of this driver are based on the rtl8180 driver skeleton
> + * from Patric Schenke & Andres Salomon.
> + *
> + * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
> + *
> + * We want to thank the Authors of those projects and the Ndiswrapper
> + * project Authors.
> + *
> + *****************************************************************************/
>
> #include <linux/string.h>
> #include "r8192U.h"
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
2016-02-01 7:01 ` Julia Lawall
@ 2016-02-01 7:31 ` ByeoungWook Kim
2016-02-01 7:35 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: ByeoungWook Kim @ 2016-02-01 7:31 UTC (permalink / raw)
To: Julia Lawall
Cc: gregkh, ksenija.stanojevic, luisbg, devel, linux-kernel,
kernel-janitors
The current realtek driver was written like my patch comments. but
Documentation/CodingStyle isn't before.
So I wrote patch like current realtek driver.
How should i do it?
Regards,
Byeoungwook.
2016-02-01 16:01 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
>
>
> On Mon, 1 Feb 2016, Byeoungwook Kim wrote:
>
>> clean up checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Signed-off-by: Byeoungwook Kim <quddnr145@gmail.com>
>> ---
>> drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++-----------------
>> 1 file changed, 20 insertions(+), 18 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
>> index 4911fef..f828e64 100644
>> --- a/drivers/staging/rtl8192u/r8192U_wx.c
>> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
>> @@ -1,21 +1,23 @@
>> -/*
>> - This file contains wireless extension handlers.
>> -
>> - This is part of rtl8180 OpenSource driver.
>> - Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
>> - Released under the terms of GPL (General Public Licence)
>> -
>> - Parts of this driver are based on the GPL part
>> - of the official realtek driver.
>> -
>> - Parts of this driver are based on the rtl8180 driver skeleton
>> - from Patric Schenke & Andres Salomon.
>> -
>> - Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
>> -
>> - We want to thank the Authors of those projects and the Ndiswrapper
>> - project Authors.
>> -*/
>> +/******************************************************************************
>
> Is the row of *s needed?
>
> julia
>
>> + *
>> + * This file contains wireless extension handlers.
>> + *
>> + * This is part of rtl8180 OpenSource driver.
>> + * Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
>> + * Released under the terms of GPL (General Public Licence)
>> + *
>> + * Parts of this driver are based on the GPL part
>> + * of the official realtek driver.
>> + *
>> + * Parts of this driver are based on the rtl8180 driver skeleton
>> + * from Patric Schenke & Andres Salomon.
>> + *
>> + * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
>> + *
>> + * We want to thank the Authors of those projects and the Ndiswrapper
>> + * project Authors.
>> + *
>> + *****************************************************************************/
>>
>> #include <linux/string.h>
>> #include "r8192U.h"
>> --
>> 2.5.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
2016-02-01 7:31 ` ByeoungWook Kim
@ 2016-02-01 7:35 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-02-01 7:35 UTC (permalink / raw)
To: ByeoungWook Kim
Cc: Julia Lawall, gregkh, ksenija.stanojevic, luisbg, devel,
linux-kernel, kernel-janitors
On Mon, 1 Feb 2016, ByeoungWook Kim wrote:
> The current realtek driver was written like my patch comments. but
> Documentation/CodingStyle isn't before.
> So I wrote patch like current realtek driver.
That is probably fine, then. Sorry for the noise. I looked at some other
code in the kernel, and it didn't have it.
julia
>
> How should i do it?
>
> Regards,
> Byeoungwook.
>
> 2016-02-01 16:01 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
> >
> >
> > On Mon, 1 Feb 2016, Byeoungwook Kim wrote:
> >
> >> clean up checkpatch warning:
> >> WARNING: Block comments use * on subsequent lines
> >>
> >> Signed-off-by: Byeoungwook Kim <quddnr145@gmail.com>
> >> ---
> >> drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++-----------------
> >> 1 file changed, 20 insertions(+), 18 deletions(-)
> >>
> >> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> >> index 4911fef..f828e64 100644
> >> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> >> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> >> @@ -1,21 +1,23 @@
> >> -/*
> >> - This file contains wireless extension handlers.
> >> -
> >> - This is part of rtl8180 OpenSource driver.
> >> - Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
> >> - Released under the terms of GPL (General Public Licence)
> >> -
> >> - Parts of this driver are based on the GPL part
> >> - of the official realtek driver.
> >> -
> >> - Parts of this driver are based on the rtl8180 driver skeleton
> >> - from Patric Schenke & Andres Salomon.
> >> -
> >> - Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
> >> -
> >> - We want to thank the Authors of those projects and the Ndiswrapper
> >> - project Authors.
> >> -*/
> >> +/******************************************************************************
> >
> > Is the row of *s needed?
> >
> > julia
> >
> >> + *
> >> + * This file contains wireless extension handlers.
> >> + *
> >> + * This is part of rtl8180 OpenSource driver.
> >> + * Copyright (C) Andrea Merello 2004-2005 <andrea.merello@gmail.com>
> >> + * Released under the terms of GPL (General Public Licence)
> >> + *
> >> + * Parts of this driver are based on the GPL part
> >> + * of the official realtek driver.
> >> + *
> >> + * Parts of this driver are based on the rtl8180 driver skeleton
> >> + * from Patric Schenke & Andres Salomon.
> >> + *
> >> + * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
> >> + *
> >> + * We want to thank the Authors of those projects and the Ndiswrapper
> >> + * project Authors.
> >> + *
> >> + *****************************************************************************/
> >>
> >> #include <linux/string.h>
> >> #include "r8192U.h"
> >> --
> >> 2.5.0
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-01 7:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 5:22 [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c Byeoungwook Kim
-- strict thread matches above, loose matches on Subject: below --
2016-02-01 5:35 Byeoungwook Kim
2016-02-01 5:16 Byeoungwook Kim
2016-02-01 7:01 ` Julia Lawall
2016-02-01 7:31 ` ByeoungWook Kim
2016-02-01 7:35 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).